Skip to content

Do not sign upload without an API secret #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kjarmicki-cloudinary wants to merge 1 commit into from
Closed

Do not sign upload without an API secret #116

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions api/uploader/upload.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ import (
"crypto/sha1"
"encoding/hex"
"encoding/json"
"errors"
"fmt"
"io"
"io/ioutil"
Expand Down Expand Up @@ -96,14 +95,11 @@ func (u *API) postAndSignForm(ctx context.Context, urlPath string, formParams ur
}

func (u *API) signRequest(requestParams url.Values) (url.Values, error) {
// No signing for OAuth Token
if u.Config.Cloud.OAuthToken != "" {
// No signing for OAuth Token or when API Secret is missing
if u.Config.Cloud.OAuthToken != "" || u.Config.Cloud.APISecret == "" {
return requestParams, nil
}

if u.Config.Cloud.APISecret == "" {
return nil, errors.New("must provide API Secret")
}
// https://cloudinary.com/documentation/upload_images#generating_authentication_signatures
// All parameters added to the method call should be included except: file, cloud_name, resource_type and your api_key.

Expand Down