Skip to content

Conversation

@samtholiya
Copy link
Collaborator

@samtholiya samtholiya commented Apr 23, 2025

what

  • We are adding pager to atmos describe component
  • We fixed the bug in the function that would assume the data is always atmosConfig and then use it to Highlight the data. This was all good if the data is atmosConfig but not for other cases.

image

why

  • We want user to give a consistent experience.

references

Summary by CodeRabbit

  • New Features
    • Introduced a pager option for the describe component command, enabling paged output with syntax highlighting for YAML and JSON formats.
    • Enhanced output formatting with customizable syntax highlighting based on user configuration.
  • Bug Fixes
    • Improved argument validation and error handling for CLI commands.
  • Documentation
    • Added documentation for the new --pager flag in the describe component command.
  • Tests
    • Added unit and integration tests covering pager functionality, output formatting, and CLI command execution.
  • Refactor
    • Refactored command execution and output handling for improved modularity, testability, and configuration management.
    • Updated output functions to accept configuration context for consistent formatting and highlighting.

samtholiya and others added 30 commits April 14, 2025 23:21
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
@mergify
Copy link

mergify bot commented May 15, 2025

💥 This pull request now has conflicts. Could you fix it @samtholiya? 🙏

@mergify mergify bot added the conflict This PR has conflicts label May 15, 2025
@samtholiya samtholiya force-pushed the feature/dev-3162-add-pager-to-atmos-describe-component-command branch from 1ac04fc to 0a35636 Compare May 15, 2025 21:48
Copy link
Member

@Benbentwo Benbentwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you explain why the pager flag isn't a bool? I'm not following why we use certain strings.

@Benbentwo Benbentwo merged commit 602f8f3 into main May 16, 2025
51 checks passed
@Benbentwo Benbentwo deleted the feature/dev-3162-add-pager-to-atmos-describe-component-command branch May 16, 2025 12:32
@mergify mergify bot removed the needs-cloudposse Needs Cloud Posse assistance label May 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

minor New features that do not break anything

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants