Fix YQ defaults for terraform.state/output YAML functions

errors/errors.go

@@ -90,16 +90,25 @@ var (
 	ErrDescribeComponent                = errors.New("failed to describe component")
 	ErrReadTerraformState               = errors.New("failed to read Terraform state")
 	ErrEvaluateTerraformBackendVariable = errors.New("failed to evaluate terraform backend variable")
-	ErrUnsupportedBackendType           = errors.New("unsupported backend type")
-	ErrProcessTerraformStateFile        = errors.New("error processing terraform state file")
-	ErrLoadAwsConfig                    = errors.New("failed to load AWS config")
-	ErrGetObjectFromS3                  = errors.New("failed to get object from S3")
-	ErrReadS3ObjectBody                 = errors.New("failed to read S3 object body")
-	ErrCreateGCSClient                  = errors.New("failed to create GCS client")
-	ErrGetObjectFromGCS                 = errors.New("failed to get object from GCS")
-	ErrReadGCSObjectBody                = errors.New("failed to read GCS object body")
-	ErrGCSBucketRequired                = errors.New("bucket is required for gcs backend")
-	ErrInvalidBackendConfig             = errors.New("invalid backend configuration")
+
+	// Recoverable YAML function errors - use YQ default if available.
+	// These errors indicate the data is not available but do not represent API failures.
+	ErrTerraformStateNotProvisioned = errors.New("terraform state not provisioned")
+	ErrTerraformOutputNotFound      = errors.New("terraform output not found")
+
+	// API/infrastructure errors - should cause non-zero exit.
+	// These errors indicate backend API failures that should not use YQ defaults.
+	ErrTerraformBackendAPIError  = errors.New("terraform backend API error")
+	ErrUnsupportedBackendType    = errors.New("unsupported backend type")
+	ErrProcessTerraformStateFile = errors.New("error processing terraform state file")
+	ErrLoadAwsConfig             = errors.New("failed to load AWS config")
+	ErrGetObjectFromS3           = errors.New("failed to get object from S3")
+	ErrReadS3ObjectBody          = errors.New("failed to read S3 object body")
+	ErrCreateGCSClient           = errors.New("failed to create GCS client")
+	ErrGetObjectFromGCS          = errors.New("failed to get object from GCS")
+	ErrReadGCSObjectBody         = errors.New("failed to read GCS object body")
+	ErrGCSBucketRequired         = errors.New("bucket is required for gcs backend")
+	ErrInvalidBackendConfig      = errors.New("invalid backend configuration")
 
 	// Azure Blob Storage specific errors.
 	ErrGetBlobFromAzure       = errors.New("failed to get blob from Azure Blob Storage")

internal/exec/describe_component_nested_authmanager_test.go

@@ -11,6 +11,92 @@ import (
 	"github.com/cloudposse/atmos/pkg/schema"
 )
 
+// setupMockStateGetter configures the global stateGetter to return mock values
+// for terraform state lookups. This allows tests to run without actual terraform state files.
+// Returns a cleanup function that must be deferred to restore the original state getter.
+func setupMockStateGetter(t *testing.T, ctrl *gomock.Controller) func() {
+	t.Helper()
+
+	mockStateGetter := NewMockTerraformStateGetter(ctrl)
+	originalGetter := stateGetter
+
+	// Configure mock to return values for all components in the fixture.
+	// Level 3 components (no dependencies).
+	mockStateGetter.EXPECT().
+		GetState(gomock.Any(), gomock.Any(), "test", "level3-component", "subnet_id", gomock.Any(), gomock.Any(), gomock.Any()).
+		Return("subnet-level3-12345", nil).
+		AnyTimes()
+	mockStateGetter.EXPECT().
+		GetState(gomock.Any(), gomock.Any(), "test", "level3-component", "cidr_block", gomock.Any(), gomock.Any(), gomock.Any()).
+		Return("10.0.3.0/24", nil).
+		AnyTimes()
+
+	// Level 2 components.
+	mockStateGetter.EXPECT().
+		GetState(gomock.Any(), gomock.Any(), "test", "level2-component", "vpc_id", gomock.Any(), gomock.Any(), gomock.Any()).
+		Return("vpc-level2-67890", nil).
+		AnyTimes()
+	mockStateGetter.EXPECT().
+		GetState(gomock.Any(), gomock.Any(), "test", "level2-component", "level3_subnet_id", gomock.Any(), gomock.Any(), gomock.Any()).
+		Return("subnet-level3-12345", nil).
+		AnyTimes()
+
+	// Auth override scenario components.
+	mockStateGetter.EXPECT().
+		GetState(gomock.Any(), gomock.Any(), "test", "auth-override-level3", "database_host", gomock.Any(), gomock.Any(), gomock.Any()).
+		Return("db.example.com", nil).
+		AnyTimes()
+	mockStateGetter.EXPECT().
+		GetState(gomock.Any(), gomock.Any(), "test", "auth-override-level2", "service_name", gomock.Any(), gomock.Any(), gomock.Any()).
+		Return("api-service", nil).
+		AnyTimes()
+	mockStateGetter.EXPECT().
+		GetState(gomock.Any(), gomock.Any(), "test", "auth-override-level2", "database_config", gomock.Any(), gomock.Any(), gomock.Any()).
+		Return("db.example.com", nil).
+		AnyTimes()
+
+	// Multi-auth scenario components.
+	mockStateGetter.EXPECT().
+		GetState(gomock.Any(), gomock.Any(), "test", "multi-auth-level3", "shared_resource_id", gomock.Any(), gomock.Any(), gomock.Any()).
+		Return("shared-12345", nil).
+		AnyTimes()
+	mockStateGetter.EXPECT().
+		GetState(gomock.Any(), gomock.Any(), "test", "multi-auth-level2", "vpc_id", gomock.Any(), gomock.Any(), gomock.Any()).
+		Return("vpc-account-b", nil).
+		AnyTimes()
+	mockStateGetter.EXPECT().
+		GetState(gomock.Any(), gomock.Any(), "test", "multi-auth-level2", "shared_resource", gomock.Any(), gomock.Any(), gomock.Any()).
+		Return("shared-12345", nil).
+		AnyTimes()
+
+	// Mixed inheritance scenario components.
+	mockStateGetter.EXPECT().
+		GetState(gomock.Any(), gomock.Any(), "test", "mixed-inherit-component", "config_value", gomock.Any(), gomock.Any(), gomock.Any()).
+		Return("inherited-auth-config", nil).
+		AnyTimes()
+	mockStateGetter.EXPECT().
+		GetState(gomock.Any(), gomock.Any(), "test", "mixed-override-component", "override_value", gomock.Any(), gomock.Any(), gomock.Any()).
+		Return("override-specific-value", nil).
+		AnyTimes()
+
+	// Deep nesting scenario components.
+	mockStateGetter.EXPECT().
+		GetState(gomock.Any(), gomock.Any(), "test", "deep-level4", "data_source", gomock.Any(), gomock.Any(), gomock.Any()).
+		Return("primary-db", nil).
+		AnyTimes()
+	mockStateGetter.EXPECT().
+		GetState(gomock.Any(), gomock.Any(), "test", "deep-level3", "data_ref", gomock.Any(), gomock.Any(), gomock.Any()).
+		Return("primary-db", nil).
+		AnyTimes()
+	mockStateGetter.EXPECT().
+		GetState(gomock.Any(), gomock.Any(), "test", "deep-level2", "nested_data", gomock.Any(), gomock.Any(), gomock.Any()).
+		Return("primary-db", nil).
+		AnyTimes()
+
+	stateGetter = mockStateGetter
+	return func() { stateGetter = originalGetter }
+}
+
 // TestNestedAuthManagerPropagation verifies that AuthManager propagates correctly
 // through multiple levels of nested !terraform.state YAML functions.
 //
@@ -34,6 +120,10 @@ func TestNestedAuthManagerPropagation(t *testing.T) {
 	ctrl := gomock.NewController(t)
 	defer ctrl.Finish()
 
+	// Setup mock state getter to return expected values without actual terraform state.
+	cleanup := setupMockStateGetter(t, ctrl)
+	defer cleanup()
+
 	// Setup: Create AuthContext with AWS credentials.
 	expectedAuthContext := &schema.AuthContext{
 		AWS: &schema.AWSAuthContext{
@@ -94,6 +184,10 @@ func TestNestedAuthManagerPropagationLevel2(t *testing.T) {
 	ctrl := gomock.NewController(t)
 	defer ctrl.Finish()
 
+	// Setup mock state getter to return expected values without actual terraform state.
+	cleanup := setupMockStateGetter(t, ctrl)
+	defer cleanup()
+
 	expectedAuthContext := &schema.AuthContext{
 		AWS: &schema.AWSAuthContext{
 			Profile:         "test-level2-identity",
@@ -293,12 +387,15 @@ func TestNestedAuthManagerWithNilAuthContext(t *testing.T) {
 }
 
 // setupNestedAuthTest creates a mock AuthManager and sets up the test directory.
-// Returns the mock controller and AuthManager for use in nested auth tests.
-func setupNestedAuthTest(t *testing.T, profile, region string) (*gomock.Controller, types.AuthManager) {
+// Returns the mock controller, AuthManager, and cleanup function for use in nested auth tests.
+func setupNestedAuthTest(t *testing.T, profile, region string) (*gomock.Controller, types.AuthManager, func()) {
 	t.Helper()
 
 	ctrl := gomock.NewController(t)
 
+	// Setup mock state getter to return expected values without actual terraform state.
+	stateCleanup := setupMockStateGetter(t, ctrl)
+
 	parentAuthContext := &schema.AuthContext{
 		AWS: &schema.AWSAuthContext{
 			Profile: profile,
@@ -320,7 +417,7 @@ func setupNestedAuthTest(t *testing.T, profile, region string) (*gomock.Controll
 	workDir := "../../tests/fixtures/scenarios/authmanager-nested-propagation"
 	t.Chdir(workDir)
 
-	return ctrl, mockAuthManager
+	return ctrl, mockAuthManager, stateCleanup
 }
 
 // TestNestedAuthManagerScenario2_AuthOverrideAtMiddleLevel verifies that
@@ -340,8 +437,9 @@ func setupNestedAuthTest(t *testing.T, profile, region string) (*gomock.Controll
 //   - Level 3 inherits Level 2's AuthManager
 //   - No IMDS timeout errors at any level.
 func TestNestedAuthManagerScenario2_AuthOverrideAtMiddleLevel(t *testing.T) {
-	ctrl, mockAuthManager := setupNestedAuthTest(t, "parent-profile", "us-east-1")
+	ctrl, mockAuthManager, stateCleanup := setupNestedAuthTest(t, "parent-profile", "us-east-1")
 	defer ctrl.Finish()
+	defer stateCleanup()
 
 	componentSection, err := ExecuteDescribeComponent(&ExecuteDescribeComponentParams{
 		Component:            "auth-override-level1",
@@ -378,8 +476,9 @@ func TestNestedAuthManagerScenario2_AuthOverrideAtMiddleLevel(t *testing.T) {
 //   - Level 3 uses account 333333333333 (inherited from Level 2)
 //   - Each level with auth config creates its own AuthManager.
 func TestNestedAuthManagerScenario3_MultipleAuthOverrides(t *testing.T) {
-	ctrl, mockAuthManager := setupNestedAuthTest(t, "global-profile", "us-east-1")
+	ctrl, mockAuthManager, stateCleanup := setupNestedAuthTest(t, "global-profile", "us-east-1")
 	defer ctrl.Finish()
+	defer stateCleanup()
 
 	componentSection, err := ExecuteDescribeComponent(&ExecuteDescribeComponentParams{
 		Component:            "multi-auth-level1",
@@ -415,8 +514,9 @@ func TestNestedAuthManagerScenario3_MultipleAuthOverrides(t *testing.T) {
 //   - mixed-override-component uses account 555555555555 (its own auth)
 //   - When mixed-override calls mixed-inherit, it inherits account 555555555555.
 func TestNestedAuthManagerScenario4_MixedInheritance(t *testing.T) {
-	ctrl, mockAuthManager := setupNestedAuthTest(t, "parent-profile", "us-west-2")
+	ctrl, mockAuthManager, stateCleanup := setupNestedAuthTest(t, "parent-profile", "us-west-2")
 	defer ctrl.Finish()
+	defer stateCleanup()
 
 	componentSection, err := ExecuteDescribeComponent(&ExecuteDescribeComponentParams{
 		Component:            "mixed-top-level",
@@ -455,8 +555,9 @@ func TestNestedAuthManagerScenario4_MixedInheritance(t *testing.T) {
 //   - Level 3 switches to account 666666666666 (Level3Access) - its own override
 //   - Level 4 inherits account 666666666666 from Level 3.
 func TestNestedAuthManagerScenario5_DeepNesting(t *testing.T) {
-	ctrl, mockAuthManager := setupNestedAuthTest(t, "global-profile", "us-east-1")
+	ctrl, mockAuthManager, stateCleanup := setupNestedAuthTest(t, "global-profile", "us-east-1")
 	defer ctrl.Finish()
+	defer stateCleanup()
 
 	componentSection, err := ExecuteDescribeComponent(&ExecuteDescribeComponentParams{
 		Component:            "deep-level1",

internal/exec/spinner_utils.go

@@ -6,9 +6,9 @@ import (
 
 	"github.com/charmbracelet/bubbles/spinner"
 	tea "github.com/charmbracelet/bubbletea"
-	log "github.com/charmbracelet/log"
 
 	"github.com/cloudposse/atmos/internal/tui/templates/term"
+	log "github.com/cloudposse/atmos/pkg/logger"
 	"github.com/cloudposse/atmos/pkg/ui/theme"
 )
 

internal/exec/terraform_state_utils.go

@@ -130,9 +130,10 @@ func GetTerraformState(
 	// Cache the result.
 	terraformStateCache.Store(stackSlug, backend)
 
-	// If `backend` is `nil`, return `nil` (the component in the stack has not been provisioned yet).
+	// If `backend` is `nil`, return a recoverable error (the component in the stack has not been provisioned yet).
+	// This allows callers to use YQ defaults if available.
 	if backend == nil {
-		return nil, nil
+		return nil, fmt.Errorf("%w for component `%s` in stack `%s`", errUtils.ErrTerraformStateNotProvisioned, component, stack)
 	}
 
 	// Get the output.

internal/exec/yaml_func_resolution_context_bench_test.go

@@ -117,7 +117,7 @@ func BenchmarkProcessCustomYamlTagsOverhead(b *testing.B) {
 	b.Run("WithoutCycleDetection", func(b *testing.B) {
 		// Simulate old behavior (direct processing without context).
 		for i := 0; i < b.N; i++ {
-			result := processNodes(atmosConfig, input, "test-stack", nil, nil)
+			result, _ := processNodes(atmosConfig, input, "test-stack", nil, nil)
 			_ = result
 		}
 	})