Fix flaky PTY tests with sh -c and printf#1890
Merged
Conversation
* feat: Add file-scoped locals to stack configurations Implements file-scoped locals for Atmos stack manifests, similar to Terraform and Terragrunt. Locals enable temporary variables that are available within a single file with dependency resolution and circular dependency detection. Key features: - Locals defined at global, component-type, and component scopes - Dependency resolution using topological sorting - Circular dependency detection with clear error messages - File-scoped isolation (no inheritance across imports) - Integration with describe locals command with provenance tracking Includes comprehensive test scenarios and documentation. 🤖 Generated with Claude Code Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com> * fix: Correct broken links in file-scoped locals blog post 🤖 Generated with Claude Code Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com> * add tests, fix issues, add/update docs * address comments, update docs --------- Co-authored-by: Claude Haiku 4.5 <noreply@anthropic.com> Co-authored-by: Andriy Knysh <aknysh@users.noreply.github.com> Co-authored-by: aknysh <andriy.knysh@gmail.com>
|
Warning This PR exceeds the recommended limit of 1,000 lines.Large PRs are difficult to review and may be rejected due to their size. Please verify that this PR does not address multiple issues. |
|
Important Cloud Posse Engineering Team Review RequiredThis pull request modifies files that require Cloud Posse's review. Please be patient, and a core maintainer will review your changes. To expedite this process, reach out to us on Slack in the |
Dependency Review✅ No vulnerabilities or license issues found.Scanned FilesNone |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1890 +/- ##
==========================================
- Coverage 73.19% 73.18% -0.01%
==========================================
Files 609 609
Lines 56766 56766
==========================================
- Hits 41548 41547 -1
+ Misses 12297 12296 -1
- Partials 2921 2923 +2
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
osterman
added
the
no-release
github-actions
bot
added
size/xs
aknysh
approved these changes
Dec 18, 2025
|
These changes were released in v1.202.0. |
|
These changes were released in v1.203.0-test.1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what
TestExecWithPTY_BasicExecutionandTestExecWithPTY_DefaultOptionsechocommand withsh -cusingprintffor more reliable output handlingwhy
The flaky tests were failing intermittently because the direct
echocommand doesn't reliably output through the PTY in all environments. Usingsh -cwithprintfand a brief sleep resolves the race condition that occurs when the subprocess exits before all output is read from the PTY.references
TestExecWithPTY_WithMaskingandTestExecWithPTY_MaskingDisabled