Skip to content

fix: surface helm/kubernetes components in describe/list/dependents wiring - #2998

Draft
Erik Osterman (Cloud Posse) (osterman) wants to merge 1 commit into
osterman/cloudformation-component-prdfrom
osterman/cfn-wiring-gap-fixes
Draft

fix: surface helm/kubernetes components in describe/list/dependents wiring#2998
Erik Osterman (Cloud Posse) (osterman) wants to merge 1 commit into
osterman/cloudformation-component-prdfrom
osterman/cfn-wiring-gap-fixes

Conversation

@osterman

@osterman Erik Osterman (Cloud Posse) (osterman) commented Aug 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

what

  • Fixes describe, list, and --affected/dependents wiring so native Helm and Kubernetes
    components are correctly surfaced, matching how Terraform/Helmfile/Packer/Ansible components
    already behave.

why

  • Helm and Kubernetes components were silently missing from describe/list/dependents output in
    some paths, which also would have masked the same class of gap for the upcoming
    aws/cloudformation component type. Fixing it here, ahead of the CloudFormation rollout, closes
    the gap for all three component types at once instead of re-discovering and re-fixing it per type.

references

  • Part of a 6-PR stack introducing the native aws/cloudformation component type; see
    cloudformation-component-prd (base) and cfn-phase4-migration-graduation (final layer) for
    the full context.

@atmos-pro

atmos-pro Bot commented Aug 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Tip

Atmos Pro  

No affected stacks workflow was detected for this pull request.
If this is expected, no action is needed.
Learn More. Ask AI.

@mergify mergify Bot added the triage Needs triage label Aug 26, 2026
@github-actions github-actions Bot added the size/m Medium size PR label Aug 26, 2026
@github-actions

github-actions Bot commented Aug 26, 2026

Copy link
Copy Markdown

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Files

None

@osterman Erik Osterman (Cloud Posse) (osterman) added the patch A minor, backward compatible change label Aug 26, 2026
@mergify
mergify Bot temporarily deployed to screengrabs August 26, 2026 17:25 Inactive
@codecov

codecov Bot commented Sep 7, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (osterman/cloudformation-component-prd@86414a6). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@                           Coverage Diff                            @@
##             osterman/cloudformation-component-prd    #2998   +/-   ##
========================================================================
  Coverage                                         ?   83.89%           
========================================================================
  Files                                            ?     1990           
  Lines                                            ?   195600           
  Branches                                         ?        0           
========================================================================
  Hits                                             ?   164107           
  Misses                                           ?    23452           
  Partials                                         ?     8041
Flag Coverage Δ
unittests 83.89% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
internal/exec/describe_affected_deleted.go 93.42% <100.00%> (ø)
internal/exec/describe_affected_utils_2.go 79.68% <100.00%> (ø)
internal/exec/describe_component.go 88.88% <100.00%> (ø)
internal/exec/describe_dependents.go 92.23% <ø> (ø)
...rnal/exec/describe_dependents_component_section.go 100.00% <100.00%> (ø)
pkg/list/extract/components.go 98.26% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@osterman @claude
fix: surface helm/kubernetes components in describe/list/dependents w…
34fbf4f 
…iring

Several built-in component types (helm, kubernetes) were silently dropped
by wiring that predates them:

- describe_component.go's FilterComputedFields had no type-specific
  fields at all, so `atmos describe component` stripped helm's
  chart/values/values_files/repositories and kubernetes' (and, cross-type,
  terraform's) provider/paths/manifests/render/generate/source/provision
  sections under the default schema filter mode.
- pkg/list/extract/components.go omitted helm/kubernetes from all three
  `atmos list components` call sites.
- describe_affected_deleted.go's deleted-component detection only checked
  terraform/helmfile/packer, so helm/kubernetes deletions went undetected.
- isComponentFolderChanged had a kubernetes case but no helm case.

findComponentSectionInCachedStacks (dependency resolution) and the
deleted-component search now generalize over the live component-provider
registry (component.ListTypes()) instead of hardcoded literal lists, so
future registered types - including the upcoming aws/cloudformation type -
need no additional touch at these two sites.

This is prep work for the aws/cloudformation component type PRD, landing
independently so its own wiring builds on a consistent base rather than
inheriting these gaps.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

patch A minor, backward compatible change size/m Medium size PR triage Needs triage

Projects

None yet

Milestone

1.229.0

Development

Successfully merging this pull request may close these issues.

1 participant

@osterman