docs: flag Homebrew FIPS gap in fips-140-mode PRD - #3074
docs: flag Homebrew FIPS gap in fips-140-mode PRD#3074Erik Osterman (Cloud Posse) (osterman) wants to merge 1 commit into
Conversation
brew install atmos misses GOFIPS140 since the formula lives in homebrew-core, outside this repo's build wiring. Links the upstream fix PR opened to close the gap. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Tip Atmos Pro
No affected stacks workflow was detected for this pull request. |
|
Warning Review limit reachedNext included review available in 11 minutes. View limit detailsLimit details: You’ve used all 4 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Dependency Review✅ No vulnerabilities or license issues found.Scanned FilesNone |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3074 +/- ##
==========================================
+ Coverage 83.86% 83.90% +0.04%
==========================================
Files 1985 1989 +4
Lines 194568 195577 +1009
==========================================
+ Hits 163171 164102 +931
- Misses 23393 23435 +42
- Partials 8004 8040 +36
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
What
Documents a Homebrew-specific gap in
docs/prd/fips-140-mode.md's "Where It's Wired In" table: theatmosformula inHomebrew/homebrew-corebuilds with a plaingo buildand noGOFIPS140, sobrew install atmosproduces a binary reporting"fips": falseinatmos version --format=json, while GitHub Release binaries (built via.goreleaser.yml, which does setGOFIPS140=latest) correctly report"fips": true.Why
atmos version --format=jsonshowingfips: falselooked like GoReleaser had regressed. Investigation confirmed GoReleaser and the localatmos buildpath (magefiles/build.go) both setGOFIPS140=latestcorrectly. The actual gap is Homebrew's from-source build, which lives entirely outside this repo. The PRD's wiring table previously claimed "every distinct Go-toolchain build invocation in the repo setsGOFIPS140" without mentioning that Homebrew isn't covered by that claim at all (it's not a build invocation in this repo), so this was an unflagged blind spot.A fix is proposed upstream: Homebrew/homebrew-core#302847 (draft, pending Homebrew maintainer review — outside this repo's control).
References
docs/prd/fips-140-mode.mdinternal/exec/version.go(isFIPSBuild()— readscrypto/fips140.Enabled()at runtime).goreleaser.yml(setsGOFIPS140=latestfor release binaries)