Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add demo workflow #872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add demo workflow #872
Changes from 19 commits
e0d4b3975ae8d869cb6f09e0777a90624682600a6f2bbedb98a2c86e63c62ca1e55e9d1fe7ffae838a8aa80687a1df005f806317cd27fceb6b30d091471ae2e77df1d08673a8a529cea3031aa04f486b1ef49fc909d0558e0b4781e1f510965608d2c22cfb862a9a70957aad43e9270097ff5626f1ce5b4d84db3f9d23b36cafabfdf2782a07390f8cb688d9bddcb50513c8e26c6387781eb5eeaa6599d2047d8ed859b4bf1618103d15df5b868732880c3e0a1e20063195b0a73a8c1b67e5fff57937491339e560ab6e383a0dccddedf76cce2bff7bd5cafd1856da733956c4e7c8db4d9245a4dc6a905f285b781dfde36e2b8df7729d2837f1243a14b38cf2f932e3100917dad6817fd307e711879d87de8ca407e23dd13c08575e1031b2203fbaf1bd158496cfb63ac16b121f92a8d17ae449615f84778edd0c83fcd04d390e67c04072c8928fac801f7b6c6665c011795f414d310fb82d65ce969089684b6fb5f47cfcd42fea57721fc784f4b76575ad662a70a4d7264ee40d02cb3da46ff4e3ba3efe95f61d24049c62d5620bcbf10fa8f1a4c84c779f3d292ec0b5dc5d5a03051246aa86196ff9a6f5dd4343824bf5b2cf83f40122a93f910fed75e637bbce73aa6c21c235f7c7fa415ef09711a55a9944b89ddbfdd1a716c88f20f910c47963f7038ff157844b6abb49b3d35edfe61fc8d4201555840284f5fda47663d9b9ef4ac942868569adc241ce85cf37cff9e0ee23c538caa63cafafea05698fb4d3dd42afacb337cd1015f73837a22cbfff424c902286File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shield your commands from the chaos of spaces and failures!
The shell commands need additional error handling and proper quoting:
Apply these improvements:
- name: Get Atmos version id: get-version run: | - VERSION=$(curl -s https://api.github.com/repos/cloudposse/atmos/releases/latest | jq -r .tag_name) + VERSION=$(curl -s --fail https://api.github.com/repos/cloudposse/atmos/releases/latest | jq -r .tag_name) + if [ -z "$VERSION" ]; then + echo "Failed to get Atmos version" + exit 1 + fi echo "version=$VERSION" >> $GITHUB_OUTPUT - name: List all .tape files id: list-tapes run: | - files=$(find . -type f -name '*.tape') - echo "matrix=$(echo -n \"$files\" | jq -R -s -c 'split(\"\\n\") | map(select(. != \"\"))')" >> $GITHUB_OUTPUT + files=$(find . -type f -name '*.tape' -print0 | jq -R -s -c 'split("\u0000") | map(select(. != ""))') + echo "matrix=$files" >> $GITHUB_OUTPUT📝 Committable suggestion
🧰 Tools
🪛 actionlint (1.7.4)
20-20: shellcheck reported issue in this script: SC2086:info:2:28: Double quote to prevent globbing and word splitting
(shellcheck)
26-26: shellcheck reported issue in this script: SC2086:info:2:26: Double quote to prevent globbing and word splitting
(shellcheck)
26-26: shellcheck reported issue in this script: SC2086:info:2:96: Double quote to prevent globbing and word splitting
(shellcheck)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Define
JOB_NAMEor derive it before useJOB_NAMEis never set, sojob_name=${JOB_NAME}will be empty, leading to invalid branch names. For example, add at the top of this block:🤖 Prompt for AI Agents (early access)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Improve variable preparation robustness!
The variable preparation step needs better error handling and validation.
- name: Prepare variables id: vars run: | VERSION="${{ needs.prepare.outputs.version }}" - JOB_NAME=$(basename "${{ matrix.file }}" | sed 's/.tape$//') + if [[ ! -f "${{ matrix.file }}" ]]; then + echo "Tape file not found: ${{ matrix.file }}" + exit 1 + fi + JOB_NAME=$(basename "${{ matrix.file }}" .tape) + if [[ -z "$JOB_NAME" ]]; then + echo "Failed to extract job name" + exit 1 + fi - echo "version=${VERSION}" >> $GITHUB_OUTPUT - echo "job_name=${JOB_NAME}" >> $GITHUB_OUTPUT - echo "branch_name=chore/update-${JOB_NAME}-for-${VERSION}" >> $GITHUB_OUTPUT + { + echo "version=${VERSION}" + echo "job_name=${JOB_NAME}" + echo "branch_name=chore/update-${JOB_NAME}-for-${VERSION}" + } >> "$GITHUB_OUTPUT"📝 Committable suggestion
🧰 Tools
🪛 actionlint (1.7.4)
109-109: shellcheck reported issue in this script: SC2129:style:3:1: Consider using { cmd1; cmd2; } >> file instead of individual redirects
(shellcheck)
109-109: shellcheck reported issue in this script: SC2086:info:3:30: Double quote to prevent globbing and word splitting
(shellcheck)
109-109: shellcheck reported issue in this script: SC2086:info:4:32: Double quote to prevent globbing and word splitting
(shellcheck)
109-109: shellcheck reported issue in this script: SC2086:info:5:63: Double quote to prevent globbing and word splitting
(shellcheck)
This file was deleted.