Conversation
- Pass `inputs.atmos-config-path` through env var and quote it in
`realpath` call to prevent command injection
- Pass `inputs.base-ref` and `inputs.skip-checkout` through env vars
and use a bash array in the `git checkout` call to prevent injection
- Remove the `affected-args` intermediate step that built a raw shell
string from unquoted `${{ inputs.* }}` expressions
- Replace `eval` in both `atmos describe affected` invocations with
bash arrays built from env vars, eliminating arbitrary code execution
via user-controlled inputs (`atmos-stack`, `identity`, etc.)
Co-authored-by: nitrocode <7775707+nitrocode@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix security weaknesses in GitHub Actions and Go code
fix(security): eliminate script injection vulnerabilities in action.yml
Mar 10, 2026
nitrocode
reviewed
Mar 10, 2026
…ted steps
Extract shared argument construction into a dedicated 'Build atmos
affected command args' step that writes args (one per line) to
${RUNNER_TEMP}/atmos-affected-args. Both 'affected-pro' and 'affected'
steps then read them back with mapfile, passing only the step-specific
flag (--upload or --file=) inline. No eval, no injection surface.
Co-authored-by: nitrocode <7775707+nitrocode@users.noreply.github.com>
aknysh
approved these changes
Mar 14, 2026
|
These changes were released in v6.10.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
${{ inputs.atmos-config-path }}inrealpathcall — useATMOS_CONFIG_PATHenv var and quote it${{ inputs.base-ref }}ingit checkoutcall — useBASE_REF/SKIP_CHECKOUTenv vars and bash array${{ inputs.* }}embedding in shell — all inputs now passed as env varsevalwith bash arrays for safe atmos command execution — eliminatedevalentirelyaffected-argsintermediate step${RUNNER_TEMP}/atmos-affected-args; both execution steps read it withmapfile🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.