Skip to content

Update dependent modules to support TF 0.12+#25

Open
Firaenix wants to merge 3 commits intocloudposse:mainfrom
Firaenix:main
Open

Update dependent modules to support TF 0.12+#25
Firaenix wants to merge 3 commits intocloudposse:mainfrom
Firaenix:main

Conversation

@Firaenix
Copy link

@Firaenix Firaenix commented Jun 4, 2024

what

  • Updated Null Label module to latest
  • Updated IAM role module to latest
  • Fixed reference to capabilities to be a list, not a string

why

  • Builds using this module werent working on TF 1.8,4

@Firaenix Firaenix requested review from a team as code owners June 4, 2024 10:04
@Firaenix Firaenix requested review from Gowiem and gberenice June 4, 2024 10:04
@mergify mergify bot added the triage Needs triage label Jun 4, 2024
@Gowiem
Copy link
Member

Gowiem commented Jun 4, 2024

/terratest

@Gowiem
Copy link
Member

Gowiem commented Jun 4, 2024

/terratest

@Gowiem
Copy link
Member

Gowiem commented Jun 5, 2024

@Firaenix unfortunately, this module needs to be updated with our testing harness + overall latest practices. We'll need someone from the core or maintainer teams to carve out some time to do that. I'll bring this up, but just an FYI that it may take some time.

@Gowiem Gowiem added the needs-cloudposse Needs Cloud Posse assistance label Jun 5, 2024
@Gowiem Gowiem self-assigned this Jun 5, 2024
@mergify
Copy link

mergify bot commented Jun 5, 2024

Important

Cloud Posse Engineering Team Review Required

This pull request modifies files that require Cloud Posse's review. Please be patient, and a core maintainer will review your changes.

To expedite this process, reach out to us on Slack in the #pr-reviews channel.

@Firaenix
Copy link
Author

Firaenix commented Jun 5, 2024

@Firaenix unfortunately, this module needs to be updated with our testing harness + overall latest practices. We'll need someone from the core or maintainer teams to carve out some time to do that. I'll bring this up, but just an FYI that it may take some time.

No skin off my back, I'm just pointing to my fork of it atm. Just thought I'd merge back onto master.

@settings settings bot removed the terraform/1.0 label Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-cloudposse Needs Cloud Posse assistance triage Needs triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants