Skip to content

Update Terraform cloudposse/s3-log-storage/aws to v2 (release/v0) - #69

Open
renovate[bot] wants to merge 1 commit into
release/v0from
renovate/release/v0-cloudposse-s3-log-storage-aws-2.x
Open

Update Terraform cloudposse/s3-log-storage/aws to v2 (release/v0)#69
renovate[bot] wants to merge 1 commit into
release/v0from
renovate/release/v0-cloudposse-s3-log-storage-aws-2.x

Conversation

@renovate

@renovate renovate Bot commented Aug 25, 2025

Copy link
Copy Markdown
Contributor

This PR contains the following updates:

Package Type Update Change
cloudposse/s3-log-storage/aws (source) module major 0.26.0 -> 2.0.0

Release Notes

cloudposse/terraform-aws-s3-log-storage (cloudposse/s3-log-storage/aws)

v2.0.0

Compare Source

Two errors when trying to plan 'Invalid count argument' and 'Incorrect attribute value type' @​goruha (#​121)

what

  • Fix
│ Error: Invalid count argument
│
│   on .terraform\modules\foo.vpc_flow_logs.s3_log_storage_bucket.aws_s3_bucket\main.tf line 64, in resource "aws_s3_bucket_logging" "default":
│   64:   count  = local.enabled && var.logging != null ? 1 : 0
│
│ The "count" value depends on resource attributes that cannot be determined until
│ apply, so Terraform cannot predict how many instances will be created. To work
│ around this, use the -target argument to first apply only the resources that the
│ count depends on.
╵

references

🤖 Automatic Updates

Fix go version in tests @​osterman (#​127)

what

  • Update go 1.24

why

  • Error loading shared library libresolv.so.2 in Go 1.20

References

Replace Makefile with atmos.yaml @​osterman (#​126)

what

  • Remove Makefile
  • Add atmos.yaml

why

  • Replace build-harness with atmos for readme genration

References

  • DEV-3229 Migrate from build-harness to atmos

v1.4.5

Compare Source

🚀 Enhancements

fix: remove join calls on bucket arn + id usage @​carterdanko-dw (#​125)

what

  • Initially put the wrong values for coditions, just needs to be a list
  • Bucket should be single resource vs joining on a list.

references

issue #122

🐛 Bug Fixes

fix: remove join calls on bucket arn + id usage @​carterdanko-dw (#​125)

what

  • Initially put the wrong values for coditions, just needs to be a list
  • Bucket should be single resource vs joining on a list.

references

issue #122

v1.4.4

Compare Source

🚀 Enhancements

Issue-122/Values expect list of strings vs string @​carterdanko-dw (#​123)

what

Updating the sqs iam permissions, as the values expects to be a list of strings vs just the single string arn that is the output of the module.

why

https://registry.terraform.io/providers/hashicorp/aws/latest/docs/data-sources/iam_policy_document#condition-1 expects to be a list of strings, vs just the single string arn of the s3 bucket.

references

Github issue #​122

🐛 Bug Fixes

Issue-122/Values expect list of strings vs string @​carterdanko-dw (#​123)

what

Updating the sqs iam permissions, as the values expects to be a list of strings vs just the single string arn that is the output of the module.

why

https://registry.terraform.io/providers/hashicorp/aws/latest/docs/data-sources/iam_policy_document#condition-1 expects to be a list of strings, vs just the single string arn of the s3 bucket.

references

Github issue #​122

🤖 Automatic Updates

Migrate new test account @​osterman (#​119)

what

  • Update .github/settings.yml
  • Update .github/chatops.yml files

why

  • Re-apply .github/settings.yml from org level to get terratest environment
  • Migrate to new test account

References

  • DEV-388 Automate clean up of test account in new organization
  • DEV-387 Update terratest to work on a shared workflow instead of a dispatch action
  • DEV-386 Update terratest to use new testing account with GitHub OIDC
Update .github/settings.yml @​osterman (#​118)

what

  • Update .github/settings.yml
  • Drop .github/auto-release.yml files

why

  • Re-apply .github/settings.yml from org level
  • Use organization level auto-release settings

references

  • DEV-1242 Add protected tags with Repository Rulesets on GitHub
Update .github/settings.yml @​osterman (#​112)

what

  • Update .github/settings.yml
  • Drop .github/auto-release.yml files

why

  • Re-apply .github/settings.yml from org level
  • Use organization level auto-release settings

references

  • DEV-1242 Add protected tags with Repository Rulesets on GitHub
Update .github/settings.yml @​osterman (#​111)

what

  • Update .github/settings.yml
  • Drop .github/auto-release.yml files

why

  • Re-apply .github/settings.yml from org level
  • Use organization level auto-release settings

references

  • DEV-1242 Add protected tags with Repository Rulesets on GitHub
Update release workflow to allow pull-requests: write @​osterman (#​110)

what

  • Update workflow (.github/workflows/release.yaml) to have permission to comment on PR

why

  • So we can support commenting on PRs with a link to the release
Update GitHub Workflows to use shared workflows from '.github' repo @​osterman (#​109)

what

  • Update workflows (.github/workflows) to use shared workflows from .github repo

why

  • Reduce nested levels of reusable workflows
Update GitHub Workflows to Fix ReviewDog TFLint Action @​osterman (#​108)

what

  • Update workflows (.github/workflows) to add issue: write permission needed by ReviewDog tflint action

why

  • The ReviewDog action will comment with line-level suggestions based on linting failures
Update GitHub workflows @​osterman (#​107)

what

  • Update workflows (.github/workflows/settings.yaml)

why

  • Support new readme generation workflow.
  • Generate banners
Use GitHub Action Workflows from `cloudposse/.github` Repo @​osterman (#​106)

what

  • Install latest GitHub Action Workflows

why

  • Use shared workflows from cldouposse/.github repository
  • Simplify management of workflows from centralized hub of configuration
Add GitHub Settings @​osterman (#​104)

what

  • Install a repository config (.github/settings.yaml)

why

  • Programmatically manage GitHub repo settings
Update README.md and docs @​cloudpossebot (#​99)

what

This is an auto-generated PR that updates the README.md and docs

why

To have most recent changes of README.md and doc from origin templates

Update Scaffolding @​osterman (#​100)

what

  • Reran make readme to rebuild README.md from README.yaml
  • Migrate to square badges
  • Add scaffolding for repo settings and Mergify

why

  • Upstream template changed in the .github repo
  • Work better with repository rulesets
  • Modernize look & feel

v1.4.3

Compare Source

🤖 Automatic Updates

Update Terraform cloudposse/s3-bucket/aws to v3.1.3 (main) @​renovate (#​95)

This PR contains the following updates:

Package Type Update Change
cloudposse/s3-bucket/aws (source) module patch 3.1.2 -> 3.1.3
Release Notes
cloudposse/terraform-aws-s3-bucket (cloudposse/s3-bucket/aws)
v3.1.3

Compare Source

Unfortunately, this change makes count unknown at plan time in certain situations. In general, you cannot use the output of compact() in count.

The solution is to stop using the deprecated policy input and revert to 3.1.2 or upgrade to 4.0.

🚀 Enhancements
Fix `source_policy_documents` combined with `var.policy` being ignored @​&#​8203;johncblandii (#&#​8203;201)
what
  • Changed var.source_policy_documents to local.source_policy_documents so var.policy usage was still supported
why
  • The ternary check uses var,source_policy_documents so var.policy being combined with var.source_policy_documents into local.source_policy_documents does not provide true for the ternary to execute
references
Update README.md and docs @​cloudpossebot (#​94)

what

This is an auto-generated PR that updates the README.md and docs

why

To have most recent changes of README.md and doc from origin templates

v1.4.2

Compare Source

🚀 Enhancements

Add `grants` input @​Nuru (#​93)

what

  • Add grants input

why

  • Some AWS services, such at Cloudfront, require specific grants for log delivery

references

v1.4.1

Compare Source

Sync .github @​max-lobur (#​89)

Rebuild '.github' dir from the template

🚀 Enhancements

Update Terraform cloudposse/s3-bucket/aws to v3.1.2 (main) @​renovate (#​91)

This PR contains the following updates:

Package Type Update Change
cloudposse/s3-bucket/aws (source) module patch 3.1.1 -> 3.1.2
Release Notes
cloudposse/terraform-aws-s3-bucket
v3.1.2: Fix Public Bucket Creation

Compare Source

What's Changed
New Contributors

Full Changelog: cloudposse/terraform-aws-s3-bucket@3.1.1...3.1.2

🤖 Automatic Updates

Update Terraform cloudposse/s3-bucket/aws to v3.1.2 (main) @​renovate (#​91)

This PR contains the following updates:

Package Type Update Change
cloudposse/s3-bucket/aws (source) module patch 3.1.1 -> 3.1.2
Release Notes
cloudposse/terraform-aws-s3-bucket
v3.1.2: Fix Public Bucket Creation

Compare Source

What's Changed
New Contributors

Full Changelog: cloudposse/terraform-aws-s3-bucket@3.1.1...3.1.2

v1.4.0

Compare Source

  • No changes

v1.3.1

Compare Source

🚀 Enhancements

Update Terraform cloudposse/s3-bucket/aws to v3.1.1 (master) @​renovate (#​88)

This PR contains the following updates:

Package Type Update Change
cloudposse/s3-bucket/aws (source) module patch 3.1.0 -> 3.1.1
Release Notes
cloudposse/terraform-aws-s3-bucket
v3.1.1

Compare Source

🐛 Bug Fixes
Revert change to Transfer Acceleration from #&#​8203;178 @​&#​8203;Nuru (#&#​8203;180)
what
  • Revert change to Transfer Acceleration from #​178
why
  • Transfer Acceleration is not available in every region, and the change in #​178 (meant to detect and correct drift) does not work (throws API errors) in regions where Transfer Acceleration is not supported

🤖 Automatic Updates

Update Terraform cloudposse/s3-bucket/aws to v3.1.1 (master) @​renovate (#​88)

This PR contains the following updates:

Package Type Update Change
cloudposse/s3-bucket/aws (source) module patch 3.1.0 -> 3.1.1
Release Notes
cloudposse/terraform-aws-s3-bucket
v3.1.1

Compare Source

🐛 Bug Fixes
Revert change to Transfer Acceleration from #&#​8203;178 @​&#​8203;Nuru (#&#​8203;180)
what
  • Revert change to Transfer Acceleration from #​178
why
  • Transfer Acceleration is not available in every region, and the change in #​178 (meant to detect and correct drift) does not work (throws API errors) in regions where Transfer Acceleration is not supported

v1.3.0

Compare Source

🚀 Enhancements

Enhance lifecycle object with optionals, limit length of bucket name @​Nuru (#​87)

what

  • Limit length of auto-generated bucket name to match AWS-imposed limit
  • Enhance lifecycle_configuration_rules to be fully defined with optional members

why

  • Avoid situation where module fails because auto-generated bucket name is too long
  • Make it easier to build a list of rules

references

v1.2.0: Support new AWS S3 defaults (ACL prohibited)

Compare Source

🤖 Automatic Updates

Update Terraform cloudposse/s3-bucket/aws to v3.1.0 @​renovate (#​85)

This PR contains the following updates:

Package Type Update Change
cloudposse/s3-bucket/aws (source) module minor 3.0.0 -> 3.1.0
Release Notes
cloudposse/terraform-aws-s3-bucket
v3.1.0

Compare Source

Make compatible with new S3 defaults. Add user permissions boundary. @​&#​8203;Nuru (#&#​8203;178)
what
  • Make compatible with new S3 defaults by setting S3 Object Ownership before setting ACL and disabling ACL if Ownership is "BucketOwnerEnforced"
  • Add optional permissions boundary input for IAM user created by this module
  • Create aws_s3_bucket_accelerate_configuration and aws_s3_bucket_versioning resources even when the feature is disabled, to enable drift detection
why
  • S3 buckets with ACLs were failing to be provisioned because the ACL was set before the bucket ownership was changed
  • Requested feature
  • See #​171
references
Always include `aws_s3_bucket_versioning` resource @​&#​8203;mviamari (#&#​8203;172)
what
  • Always create an aws_s3_bucket_versioning resource to track changes made to bucket versioning configuration
why
  • When there is no aws_s3_bucket_versioning, the expectation is that the bucket versioning is disabled/suspend for the bucket. If bucket versioning is turned on outside of terraform (e.g. through the console), the change is not detected by terraform unless the aws_s3_bucket_versioning resource exists.
references
  • Closes #​171
Add support for permission boundaries on replication IAM role @​&#​8203;mchristopher (#&#​8203;170)
what
why
  • Our AWS environment enforces permission boundaries on all IAM roles to follow AWS best practices with security.
references
🤖 Automatic Updates
Update README.md and docs @​&#​8203;cloudpossebot (#&#​8203;164)
what

This is an auto-generated PR that updates the README.md and docs

why

To have most recent changes of README.md and doc from origin templates

v1.1.0

Compare Source

Adding "object_lock_configuration" variable @​ramses999 (#​84)

what

Adding "object_lock_configuration" variable which is used in module "cloudposse/s3-bucket/aws"

why

Must be able to use the Object Lock option for S3 in this module

references

https://github.com/cloudposse/terraform-aws-s3-bucket/blob/6837ed7b2f2460043d6be3981f16ed90563fd12a/main.tf#L5

v1.0.0

Compare Source

Important Notes

  • Terraform version 1.3.0 and Terraform AWS version 4.9.0 or later are required
  • The new bucket_key_enabled flag defaults to false for backward compatibility. At one point we recommend setting it to true for significant savings on KMS usage, but since bucket keys are only reused within a user session, it is not clear if it provides any savings at all. See AWS docs for more information.
  • The new lifecycle_configuration_rules input replaces the now deprecated individual inputs for individual settings of a single lifecycle rule. See the terraform-aws-s3-bucket documentation for details on how to specify lifecycles using lifecycle_configuration_rules. This mechanism is much more flexible and closely follows the Terraform aws_s3_bucket_lifecycle_configuration resource.
  • The new source_policy_documents input replaces the now deprecated policy input to match changes to the aws_iam_policy_document resource
  • You can now select default values for (non-deprecated) inputs by setting them to null
  • With Terraform 1.3 the manual interventions documented for upgrading to this module's versions 0.27.0 and 0.28.0 are no longer needed. You can safely upgrade from any earlier version to this one (although we always recommend leaving force_destroy at its default value of false, and if you have it set to true but want extra safety against the S3 bucket being destroyed, set it to false before upgrading).
  • The force_destroy_enabled flag introduced in v0.27.0 has been removed
  • In version 0.28.0, old lifecycle rule variables were deprecated and the new lifecycle_configuration_rules input was introduced. In that version, you would continue to get the old default lifecycle rule even if you supplied new rules via lifecycle_configuration_rules. Now, the default behavior is to ignore all the deprecated lifecycle inputs when the lifecycle_configuration_rules input is not empty, unless you explicitly set lifecycle_rule_enabled to true.
Enhancements
Automate upgrade using `moved` blocks @​Nuru (#​81)

what

  • Automate the upgrade process from v0.26.0 or earlier by using moved block functionality introduced in Terraform 1.3.0
  • Add nullable = false for module input variables which have a default value and where null is not a sensible/handled value for the variable.

why

  • Safely upgrade without loss of data or manual intervention
  • Allow users to select default values by setting inputs to null, closes #​63

v0.28.3: Not recommended, use v0.26.0 or v1.x instead

Compare Source

Update: This version no longer recommended

With the release of version 1.0.0 of this module, use of this version is no longer recommended. When you are able to use Terraform v1.3.0 or later and Terraform AWS provider v4.9.0 or later, upgrade directly to v1.0.0 or later of this module.

🤖 Automatic Updates

Update Terraform cloudposse/s3-bucket/aws to v3 @​renovate (#​78)

This PR contains the following updates:

Package Type Update Change
cloudposse/s3-bucket/aws (source) module major 2.0.1 -> 3.0.0

v0.28.2: Action required if updating from prior to v0.28.0

Compare Source

Update: This version no longer recommended

With the release of version 1.0.0 of this module, use of this version is no longer recommended. When you are able to use Terraform v1.3.0 or later and Terraform AWS provider v4.9.0 or later, upgrade directly to v1.0.0 or later of this module.

v0.28.0 introduced breaking changes with high risk of permanent data loss. See release notes there. This is only a safe upgrade if upgrading from v0.28.0.

We will convert to semantic versioning (incrementing the major version number for breaking changes), but having missed the opportunity to do that for earlier versions of this module, we are waiting for the next major change, expected to be soon after Terraform v1.3 is released.

🤖 Automatic Updates

Update Terraform cloudposse/s3-bucket/aws to v2.0.1 @​renovate (#​76)

This PR contains the following updates:

Package Type Update Change
cloudposse/s3-bucket/aws (source) module patch 2.0.0 -> 2.0.1

v0.28.1: accidental release, do not use

Compare Source

v0.28.0 introduced breaking changes with high risk of permanent data loss. See release notes there. This is only a safe upgrade if upgrading from v0.28.0.

We will convert to semantic versioning (incrementing the major version number for breaking changes), but having missed the opportunity to do that for earlier versions of this module, we are waiting for the next major change, expected to be soon after Terraform v1.3 is released.

git.io->cloudposse.tools update @​dylanbannon (#​73)

what and why

Change all references to git.io/build-harness into cloudposse.tools/build-harness, since git.io redirects will stop working on April 29th, 2022.

References

  • DEV-143

🤖 Automatic Updates

Update Terraform cloudposse/s3-bucket/aws to v2 @​renovate (#​72)

This PR contains the following updates:

Package Type Update Change
cloudposse/s3-bucket/aws (source) module major 0.49.0 -> 2.0.3

v0.28.0: (Action Needed) Support AWS v4 provider

Compare Source

WARNING, DATA LOSS LIKELY if you do not follow upgrade instructions:

🚀 Enhancements

Support AWS v4 provider @​Nuru (#​71)

what

  • Migrate to AWS v4 Terraform provider
  • Add features
    • Allow full S3 storage lifecycle configuration
    • Allow multiple bucket policy documents
    • Allow specifying the bucket name directly, rather than requiring it to be generated by null-label
    • Allow specifying S3 object ownership
    • Allow enabling S3 bucket keys for encryption
  • Deprecate variable by variable specification of a single storage lifecycle rule
  • Add extra safety measure force_destroy_enabled

why

  • AWS v4 broke this module
  • Feature parity
  • Replaced with more power and more flexible input
  • Reduce the chance that automated upgrades will cause data loss

references

v0.27.0: (WARNING: Potential Data Loss) Prepare for AWS provider v4

Compare Source

Update: This version no longer recommended

With the release of version 1.0.0 of this module, use of this version is no longer recommended. When you are able to use Terraform v1.3.0 or later and Terraform AWS provider v4.9.0 or later, upgrade directly to v1.0.0 or later of this module.

Warning: Potential total data loss

This release is a refactoring in preparation for supporting Terraform AWS Provider v4. One feature was removed, but otherwise there are no changes to inputs or behavior. However, the Terraform "addresses" of resources have changed, so you are need to run several terraform state mv commands.

Warning: failure to run the required terraform state mv commands will cause Terraform to delete your existing S3 bucket and create a new one, deleting all the data stored in the bucket in the process.

Details on how to safely upgrade are in this repository's Wiki here

Support for "MFA delete" removed

In #​54 a contributor added support for MFA delete via the versioning_mfa_delete_enabled. In AWS provider version 3.x this argument was documented with the caveat

This cannot be used to toggle this setting but is available to allow managed buckets to reflect the state in AWS.

With AWS provider version 4.0, this argument now does toggle the setting. Unfortunately, that adds the requirement then when it is enabled, you must supply a current MFA token every time you run terraform apply. That is not compatible with automation, and therefore we have no intention to support it and have removed the versioning_mfa_delete_enabled input.

🚀 Enhancements

Refactor to use s3-bucket module, update in general @​Nuru (#​66)

what

  • Refactor to use terraform-aws-s3-bucket
  • Remove support for mfa_delete
  • Pin AWS provider < 4.0 and disable Renovate bot, closes #​64
  • General updates

why

  • Simplify maintenance and standardize on single S3 bucket module, in preparation for upgrade to Terraform AWS provider v4
  • With Terraform AWS provider v4, having mfa_delete enabled requires entering an MFA token for every Terraform operation, which is incompatible with automation. Users requiring mfa_delete should either not use Terraform or create their own fork.
  • Current module does not work with AWS v4, but Renovate would try to update it anyway
  • Stay current with boilerplate and management tools

notes

This is the first of 2 upgrade releases to get this module to support Terraform AWS Provider v4. We are breaking it into 2 releases so that users have the option of upgrading step-by-step rather than all at once. Upgrade instructions are here.

Cleanups and safety checks for upgrade @​Nuru (#​70)

what

  • Add warning to README and error when force_destroy is true
  • Maintain rule name for lifecycle rule
  • Disable Renovate bot

why

  • If force_destroy is true then an automated, unattended process could cause the S3 bucket to be deleted and all data in it irretrievably lost
  • Remove an unwanted and unneeded source of changes created by upgrading
  • This version should not be updated, it is pinned for compability

references

Closes Renovate PRs:

  • Closes #​67 (do not want)
  • Closes #​68 (incorporated via build-harness)
  • Closes #​69 (do not want)

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate
renovate Bot requested review from a team as code owners August 25, 2025 20:01
@renovate renovate Bot added the auto-update This PR was automatically generated label Aug 25, 2025
@renovate
renovate Bot requested review from Veronika Gnilitska (gberenice) and yangci (oycyc) and removed request for a team August 25, 2025 20:01
@mergify

mergify Bot commented Aug 25, 2025

Copy link
Copy Markdown

/terratest

@renovate

renovate Bot commented Aug 25, 2025

Copy link
Copy Markdown
Contributor Author

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gberenice Veronika Gnilitska (gberenice) Awaiting requested review from gberenice gberenice is a code owner automatically assigned from cloudposse/contributors
@oycyc yangci (oycyc) Awaiting requested review from oycyc oycyc is a code owner automatically assigned from cloudposse/contributors

Assignees

No one assigned

Labels

auto-update This PR was automatically generated

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

0 participants