Replace cidr_block with ipv4_cidr_block in README#123
Open
MajinBuuOnSecurity wants to merge 2 commits intocloudposse:mainfrom
Open
Replace cidr_block with ipv4_cidr_block in README#123MajinBuuOnSecurity wants to merge 2 commits intocloudposse:mainfrom
MajinBuuOnSecurity wants to merge 2 commits intocloudposse:mainfrom
Conversation
joe-niland
requested changes
Sep 4, 2023
Member
joe-niland
left a comment
There was a problem hiding this comment.
Thanks for your PR.
To make this change, please update README.yaml then run:
make init
make readme
|
/terratest |
|
From the top of the READme file involved @MajinBuuOnSecurity Can you apply the fix to the right file and execute the rebuild? |
|
Thanks @MajinBuuOnSecurity for creating this pull request! A maintainer will review your changes shortly. Please don't be discouraged if it takes a while. While you wait, make sure to review our contributor guidelines. Tip Need help or want to ask for a PR review to be expedited?Join us on Slack in the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves #121, see https://github.com/cloudposse/terraform-aws-dynamic-subnets#usage for further evidence.