chore: Add additional metadata #81
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Al-Dani
reviewed
May 14, 2025
| @@ -9,8 +9,10 @@ import { | |||
| useComponentMetadata, | |||
| } from "@cloudscape-design/component-toolkit/internal"; | |||
|
|
|||
| import { PACKAGE_SOURCE, PACKAGE_VERSION } from "../environment"; | |||
| import { PACKAGE_SOURCE, PACKAGE_VERSION, THEME } from "../environment"; | |||
| import { getVisualTheme } from "../utils/get-visual-theme"; | |||
There was a problem hiding this comment.
one meta-question: why do we have this utils copied to all packages instead of component-toolkit?
There was a problem hiding this comment.
Coming in the future: cloudscape-design/component-toolkit#122
Al-Dani
approved these changes
May 14, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #81 +/- ##
==========================================
+ Coverage 99.23% 99.25% +0.02%
==========================================
Files 29 29
Lines 260 268 +8
Branches 31 31
==========================================
+ Hits 258 266 +8
Misses 1 1
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding additional metadata after this change cloudscape-design/component-toolkit#132
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.