Skip to content

fix: Hide new pageIndex logic behind flag #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 13, 2025
Merged

Conversation

gethinwebster
Copy link
Member

@gethinwebster gethinwebster commented Mar 12, 2025

Issue #, if available:

Description of changes:

Revision of #99 so that the new logic is behind a flag, as the change turned out to be breaking for some customers.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Mar 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.22%. Comparing base (b6007dd) to head (9d67b51).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #103   +/-   ##
=======================================
  Coverage   99.22%   99.22%           
=======================================
  Files          14       14           
  Lines         515      515           
  Branches      183      183           
=======================================
  Hits          511      511           
  Misses          4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gethinwebster gethinwebster marked this pull request as ready for review March 12, 2025 14:08
@gethinwebster gethinwebster requested a review from a team as a code owner March 12, 2025 14:08
@gethinwebster gethinwebster requested review from orangevolon and removed request for a team March 12, 2025 14:08
@gethinwebster gethinwebster added this pull request to the merge queue Mar 13, 2025
Merged via the queue into main with commit f813f87 Mar 13, 2025
36 checks passed
@gethinwebster gethinwebster deleted the page-range-fix branch March 13, 2025 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants