feat: Add support for iframes in page scanner utility - #144
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #144 +/- ##
==========================================
+ Coverage 99.38% 99.39% +0.01%
==========================================
Files 33 33
Lines 810 826 +16
Branches 214 232 +18
==========================================
+ Hits 805 821 +16
Misses 5 5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fralongo
force-pushed
the
flongo-page-scanner-3
branch
from
July 14, 2025 12:32
5928a54 to
a55841c
Compare
jperals
reviewed
Jul 14, 2025
| test('with iframes', async () => { | ||
| const { container } = render(<AppWithIframe />); | ||
| await waitFor(() => { | ||
| ( |
Member
There was a problem hiding this comment.
Does this waitFor do anything? From the docs:
Returning a falsy condition is not sufficient to trigger a retry, the callback must throw an error in order to retry the condition
Member
Author
There was a problem hiding this comment.
Interesting, I didn't know. Let me remove the waiting then.
jperals
approved these changes
Jul 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.