Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Wrap alert and flash actions more responsively #3338

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

gethinwebster
Copy link
Member

@gethinwebster gethinwebster commented Mar 7, 2025

Description

Wrap alert and flash actions more responsively, based on actual content rather than breakpoints. This ensures they make the best use of the available space (not wrapping until smaller widths when content is small, and wrapping already at larger widths when content is longer).

Related links, issue #, if available: AWSUI-55633, AWSUI-60122

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Mar 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.46%. Comparing base (a80c1cb) to head (d4b3ad9).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3338   +/-   ##
=======================================
  Coverage   96.46%   96.46%           
=======================================
  Files         805      805           
  Lines       23004    23019   +15     
  Branches     7960     7955    -5     
=======================================
+ Hits        22190    22205   +15     
- Misses        760      807   +47     
+ Partials       54        7   -47     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gethinwebster gethinwebster force-pushed the dev-v3-gethinw-alert-wrapping branch from fb898b3 to 7dafe93 Compare March 11, 2025 12:48
@gethinwebster gethinwebster force-pushed the dev-v3-gethinw-alert-wrapping branch from 7dafe93 to 6de8d7a Compare March 24, 2025 12:23
@gethinwebster gethinwebster force-pushed the dev-v3-gethinw-alert-wrapping branch from 6de8d7a to af9329d Compare March 26, 2025 12:40
@gethinwebster gethinwebster force-pushed the dev-v3-gethinw-alert-wrapping branch from af9329d to 9adc7a2 Compare March 31, 2025 14:01
@gethinwebster gethinwebster changed the title fix: Wrap alert actions more eagerly fix: Wrap alert actions more responsively Mar 31, 2025
@gethinwebster gethinwebster force-pushed the dev-v3-gethinw-alert-wrapping branch from 1f3d816 to daa6665 Compare April 1, 2025 08:58
@gethinwebster gethinwebster force-pushed the dev-v3-gethinw-alert-wrapping branch from daa6665 to 548c4e1 Compare April 1, 2025 15:28
@gethinwebster gethinwebster changed the title fix: Wrap alert actions more responsively fix: Wrap alert and flash actions more responsively Apr 2, 2025
@gethinwebster gethinwebster marked this pull request as ready for review April 2, 2025 07:41
@gethinwebster gethinwebster requested a review from a team as a code owner April 2, 2025 07:41
@gethinwebster gethinwebster requested review from just-boris and removed request for a team April 2, 2025 07:41
ref={headerRef}
>
{header}
<div className={styles['alert-wrapper']}>
Copy link
Member Author

@gethinwebster gethinwebster Apr 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking into this to see if it might cause problems with test utils cross-version compatibility

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(looks to be fine, no use of child combinators)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant