-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Wrap alert and flash actions more responsively #3338
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3338 +/- ##
=======================================
Coverage 96.46% 96.46%
=======================================
Files 805 805
Lines 23004 23019 +15
Branches 7960 7955 -5
=======================================
+ Hits 22190 22205 +15
- Misses 760 807 +47
+ Partials 54 7 -47 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fb898b3
to
7dafe93
Compare
7dafe93
to
6de8d7a
Compare
6de8d7a
to
af9329d
Compare
af9329d
to
9adc7a2
Compare
1f3d816
to
daa6665
Compare
daa6665
to
548c4e1
Compare
ref={headerRef} | ||
> | ||
{header} | ||
<div className={styles['alert-wrapper']}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking into this to see if it might cause problems with test utils cross-version compatibility
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(looks to be fine, no use of child combinators)
6bf665c
to
cfd0b91
Compare
Description
Wrap alert and flash actions more responsively, based on actual content rather than breakpoints. This ensures they make the best use of the available space (not wrapping until smaller widths when content is small, and wrapping already at larger widths when content is longer).
Related links, issue #, if available: AWSUI-55633, AWSUI-60122
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md
.CONTRIBUTING.md
.Security
checkSafeUrl
function.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.