chore: VR improvements #3374
Open
chore: VR improvements #3374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3374 +/- ##
==========================================
- Coverage 96.51% 96.51% -0.01%
==========================================
Files 806 806
Lines 23032 23029 -3
Branches 7551 7962 +411
==========================================
- Hits 22230 22227 -3
Misses 795 795
Partials 7 7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
at-susie
requested review from
cansuaa and
just-boris
and removed request for
a team and
cansuaa
just-boris
reviewed
Apr 1, 2025
…cape-design/components into implement-vr-improvements
connorlanigan
previously approved these changes
Apr 14, 2025
just-boris
previously approved these changes
Apr 14, 2025
…cape-design/components into implement-vr-improvements
just-boris
previously approved these changes
Apr 16, 2025
src/segmented-control/styles.scss
Outdated
| border-start-start-radius: awsui.$border-radius-button; | ||
| border-start-end-radius: awsui.$border-radius-button; | ||
| border-end-start-radius: awsui.$border-radius-button; | ||
| border-end-end-radius: awsui.$border-radius-button; | ||
| align-items: center; | ||
| min-block-size: calc(awsui.$line-height-body-m + awsui.$space-static-xxs); | ||
| padding-inline: awsui.$space-static-xxxs; | ||
| padding-block: calc(seg.$segment-gap / 2 - awsui.$border-width-field); | ||
| padding-inline: calc(seg.$segment-gap - 1px); |
There was a problem hiding this comment.
Why is this 1px? Does that need to match some other element / variable?
… min height of prompt-input
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As part of VR improvements, this PR changes 1) the page background color of AppLayoutToolbar to create a greater visual hierarchy in a page, and 2) change the stroke width of form field controls from 2px to 1px.
Related links, issue #, if available: n/a
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.