Skip to content

feat: KeyValuePairs update pair label to ReactNode #3430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ernst-dev
Copy link
Member

Description

Update the label property to support ReactNode for custom components such as adding icons to the labels.

image

Related links, issue #, if available: n/a
AWSUI-55326
08LJAUcYhg64

How has this been tested?

Manual, unit

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Apr 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.51%. Comparing base (058c6ee) to head (e27a2ea).

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #3430    +/-   ##
========================================
  Coverage   96.51%   96.51%            
========================================
  Files         806      806            
  Lines       23032    23032            
  Branches     7551     7973   +422     
========================================
  Hits        22230    22230            
+ Misses        795      748    -47     
- Partials        7       54    +47     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ernst-dev ernst-dev marked this pull request as ready for review April 17, 2025 10:46
@ernst-dev ernst-dev requested a review from a team as a code owner April 17, 2025 10:46
@ernst-dev ernst-dev requested review from orangevolon and removed request for a team April 17, 2025 10:46
@@ -27,6 +30,34 @@ export default function () {
label: 'Label for key',
value: 'Value',
},
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could take these three to the pemutations file and keep a simple one (the first one for example) in this file.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved them over

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants