Repository navigation
Conversation
amanabiy
force-pushed
the
fix/listbox-home-end
branch
from
November 6, 2026 09:13
9247cbf to
ea49979
Compare
amanabiy
changed the base branch from
feat/add-option-list
to
fix/select-multiselect-listbox-alignment
November 6, 2026 09:16
amanabiy
marked this pull request as ready for review
November 6, 2026 09:26
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## fix/select-multiselect-listbox-alignment #5262 +/- ##
=========================================================================
Coverage 97.85% 97.85%
=========================================================================
Files 1012 1012
Lines 32731 32736 +5
Branches 12128 12129 +1
=========================================================================
+ Hits 32030 32035 +5
Misses 661 661
Partials 40 40 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
amanabiy
force-pushed
the
fix/listbox-home-end
branch
from
November 6, 2026 10:05
ea49979 to
efcd14e
Compare
…ptionList When the list element has focus, Home and End moved the highlight to the first or last option, and the browser also ran its native action, which scrolls the page or a scroll container to its top or bottom. The list's keydown handler from useListbox now prevents the native Home and End action. This applies to Select and Multiselect without a filter, embedded Multiselect and OptionList. With a filter, focus is in the input, and Home and End keep moving the text cursor.
jperals
force-pushed
the
fix/listbox-home-end
branch
from
November 6, 2026 14:28
efcd14e to
5f51d48
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When the list element has focus, Home and End moved the highlight and the browser also ran its native action, which scrolls the page or a scroll container to its top or bottom. The list's keydown handler from
useListboxnow prevents the native Home and End action. This applies to Select and Multiselect without a filter, embedded Multiselect and OptionList. With a filter, focus is in the input, and Home and End keep moving the text cursor.From the OptionList accessibility review, question 2 (Home and End).
Related links, issue #, if available: AfZkAA6G9O2X
How has this been tested?
Unit tests in
use-listbox.test.tsx: on the list, Home and End move the highlight and prevent the native action; through the filter input handler, they keep it. Unit tests for OptionList, Select, Multiselect, Autosuggest, Property filter and the shared list code pass, and eslint and tsc pass.Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.