Repository navigation
fix: Use theme-aware navigation toggle icon in AppLayout toolbar skeleton - #5265
Merged
Harsh-Anand-Singh merged 1 commit intoNov 6, 2026
Merged
Conversation
Harsh-Anand-Singh
force-pushed
the
fix/app-layout-toolbar-skeleton-one-theme-icon
branch
from
November 6, 2026 13:54
682312d to
7454232
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5265 +/- ##
=======================================
Coverage 97.83% 97.83%
=======================================
Files 1008 1008
Lines 32582 32584 +2
Branches 12092 12092
=======================================
+ Hits 31878 31880 +2
- Misses 663 698 +35
+ Partials 41 6 -35 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Harsh-Anand-Singh
marked this pull request as ready for review
November 6, 2026 14:16
Harsh-Anand-Singh
enabled auto-merge
November 6, 2026 14:26
YueyingLu
approved these changes
Nov 6, 2026
YueyingLu
reviewed
Nov 6, 2026
| ariaLabel={ariaLabels?.navigationToggle ?? undefined} | ||
| ariaExpanded={!drawerExpandedMode && navigationOpen} | ||
| iconName="menu" | ||
| iconName={isOneTheme ? 'side-bar' : 'menu'} |
Member
There was a problem hiding this comment.
Suggestion: can we make this Trigger a shared component in skeleton and toolbar, so we can avoid this discrepancy.
Harsh-Anand-Singh
deleted the
fix/app-layout-toolbar-skeleton-one-theme-icon
branch
November 6, 2026 15:56
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In One Theme the AppLayout toolbar renders the
side-baricon for the navigation toggle (toolbar/index.tsx:isThemeActive(Theme.OneTheme) ? 'side-bar' : 'menu'). The toolbar skeleton (ToolbarSkeletonStructure), shown while the widgetized toolbar implementation is loading and during SSR, hardcodesiconName="menu". When the widget replaces the skeleton the icon visibly flips frommenutoside-bar(reported in AWS console ticket AWSUI-62419, seen on the console home page where the AppLayout widget is enabled).This change makes the skeleton use the same theme check as the real toolbar so both render the same icon. VR and classic are unaffected (
isThemeActive(Theme.OneTheme)is false there, so the icon staysmenu).How has this been tested?
Unit tests added in
skeleton.test.tsxcovering both icons in the loading (skeleton) state. Existing app-layout tests pass.Note for reviewers: the skeleton lives in the host bundle, so a console gets this fix via its own Cloudscape version, not via the widget.