Skip to content

Fixed validator for task_type for SSM MaintenanceWindowTask #1077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fixed validator for task_type for SSM MaintenanceWindowTask #1077

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dbfeee6
Fixed validator for task_type to match reality - AWS CF documentation…
haylix-edward Jun 21, 2018
8a48574
Update test to match change to validators
haylix-edward Jun 21, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/test_validators.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,7 @@ def test_operating_system(self):
operating_system(s)

def test_task_type(self):
for s in ['RUN_COMMAND', 'AUTOMATION', 'LAMBDA', 'STEP_FUNCTION']:
for s in ['RUN_COMMAND', 'AUTOMATION', 'LAMBDA', 'STEP_FUNCTIONS']:
task_type(s)
for s in ['', 'foo', 'a', 'l@mbda', 'STEPFUNCTION']:
with self.assertRaises(ValueError):
Expand Down
2 changes: 1 addition & 1 deletion troposphere/validators.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,7 @@ def notification_event(events):


def task_type(task):
valid_tasks = ['RUN_COMMAND', 'AUTOMATION', 'LAMBDA', 'STEP_FUNCTION']
valid_tasks = ['RUN_COMMAND', 'AUTOMATION', 'LAMBDA', 'STEP_FUNCTIONS']
if task not in valid_tasks:
raise ValueError(
'TaskType must be one of: "%s"' % (
Expand Down