Validate the type for Tags #2270
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change Tags (which is a subclass of AWSHelperFn) would not do validation of the expected type and it prevented validation of Json style Tags needing a dict.
gautaz
approved these changes
Sep 29, 2024
There was a problem hiding this comment.
I have tested the branch with a JobDefinition (my original test case) with both dict and Tags, everything seems fine and working.
The test passes with dict and fails on Tags with error JobDefinition.Tags is <class 'troposphere.Tags'>, expected <class 'dict'> which is exactly what I expected.
Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change Tags (which is a subclass of AWSHelperFn) would not do validation of the expected type and it prevented validation of Json style Tags needing a dict.
Fixes #2268