Allow AWSHelperFn for Tags properties #2271
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of checking the property name, we check the type of the value this means that the Tags class gets checked, but other helper functions are allowed
benbridts
changed the title
jvdmr
approved these changes
Oct 2, 2024
|
@benbridts apologies for the regression and thank you for the PR. I will create a new release when I get time this morning. |
|
Released as 4.8.3. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of checking the property name, we check the type of the value. This means that the Tags class gets checked, but other helper functions are allowed
We were running into this issue, because we have a custom resource that outputs a tag list.
I've also added tests for this case