Skip to content

Conversation

royffeng
Copy link
Contributor

fixes #2324

@markpeek
Copy link
Member

Thank you for the PR. I noticed some other missing properties in there as well. Would you like to add these as well to your PR?

diff --git a/troposphere/serverless.py b/troposphere/serverless.py
index 3082f504..27a510c1 100644
--- a/troposphere/serverless.py
+++ b/troposphere/serverless.py
@@ -21,6 +21,7 @@ from .awslambda import (
     ProvisionedConcurrencyConfiguration,
     ProvisionedPollerConfig,
     RuntimeManagementConfig,
+    SchemaRegistryConfig,
     SnapStart,
     SourceAccessConfiguration,
     VPCConfig,
@@ -731,8 +732,10 @@ class MSKEvent(AWSObject):
         "ConsumerGroupId": (str, False),
         "DestinationConfig": (DestinationConfig, False),
         "FilterCriteria": (FilterCriteria, False),
+        "KmsKeyArn": (str, False),
         "MaximumBatchingWindowInSeconds": (integer, False),
         "ProvisionedPollerConfig": (ProvisionedPollerConfig, False),
+        "SchemaRegistryConfig": (SchemaRegistryConfig, False),
         "SourceAccessConfigurations": ([SourceAccessConfiguration], False),
         "StartingPosition": (str, True),
         "StartingPositionTimestamp": (double, False),

@royffeng
Copy link
Contributor Author

added SchemaRegistryConfig and KmsKeyArn!

@markpeek markpeek merged commit 4b6bac1 into cloudtools:main Aug 20, 2025
1 of 6 checks passed
@markpeek
Copy link
Member

Thank you for the PR and adding the other missing properties.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Lambda ESM BatchSize param support for serverless MSKEvent

2 participants