Skip to content

Conversation

rodolfo-nadai-encora
Copy link

Hopefully this is fine, but feel free to ask any changes need it! PLEASE!

This is adding a new engine to be available in the RDS validator.

Closes

@markpeek
Copy link
Member

markpeek commented Oct 1, 2025

Thank you for the PR. I'd like to see a couple of changes outside of your change to this validator. Let me know if you want to do it or have me take it on.

  1. Reorder the list alphabetically to better match up with the Valid Values listed here
  2. Add any other missing values.
  3. Figure out what to do with ones not listed in the documentation. I'd probably say just list them at the bottom and I can purge them sometime in the future.
  4. Convert it from a tuple to a dict...the performance likely doesn't matter but hey, why not save some cycles?
  5. And then ensure "make fix lint test" is successful with the changes.

@rodolfo-nadai-encora
Copy link
Author

Yeah... NP, will do!

@rdenadai
Copy link
Contributor

rdenadai commented Oct 1, 2025

Please close this in favor of #2335

@markpeek
Copy link
Member

markpeek commented Oct 1, 2025

Closed per author

@markpeek markpeek closed this Oct 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants