Skip to content

Conversation

jaekunchoi
Copy link

@jaekunchoi jaekunchoi commented May 22, 2017

Ref is now supported in the method from_file of helper file.
Also added unit test
Should address issue #724
@markpeek please review. I was able to successfully run userdata with Ref on AWS.

@markpeek markpeek added this to the 1.9.4 milestone May 25, 2017
@markpeek
Copy link
Member

markpeek commented Jun 4, 2017

Nice change. I have two questions:

  1. It seems this will always look for Ref. Perhaps it should be an option or another function name search for Ref.
  2. Right now it only looks for 1 Ref. Is there a use case to look for multiple Ref's?

@jaekunchoi
Copy link
Author

@markpeek thanks for the feedback. I've updated userdata script with multiple refs and asserting these results in the test. It passes with mutliple Refs being replaced.
I've also added an option to include Ref.

Thanks again!

@markpeek markpeek modified the milestones: 1.9.5, 1.9.4 Jul 3, 2017
@jaekunchoi
Copy link
Author

@markpeek do you have any feedback on the changes?

@ollikaven
Copy link

Plans to merge this?

@PatMyron PatMyron modified the milestones: 1.9.5, 1.9.6 Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants