json_checker - recursively validate dictionary while ignoring non-string types #946
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Additional tests and concise reproductions in code will be coming soon |
thejohnlin
changed the title
thejohnlin
changed the title
thejohnlin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, using a Ref inside the Schema parameter to create a new apigateway.Model resource will result in an Exception from attempting to validate the dictionary via json.dumps(). This PR is an attempt to enable this use-case by only attempting json.dumps() on the values of type basestring in the dictionary.
This also seems to affect cloudwatch.Dashboard, which also uses json_checker to validate the DashboardBody property.