Skip to content

feat(model): add atlas cloud chat model#816

Open
lucaszhu-hue wants to merge 7 commits into
cloudwego:mainfrom
lucaszhu-hue:feat/atlascloud-provider
Open

feat(model): add atlas cloud chat model#816
lucaszhu-hue wants to merge 7 commits into
cloudwego:mainfrom
lucaszhu-hue:feat/atlascloud-provider

Conversation

@lucaszhu-hue

@lucaszhu-hue lucaszhu-hue commented Apr 30, 2026

Copy link
Copy Markdown

en:
This PR adds support for the Atlas Cloud chat model provider, including necessary API configurations and model definitions.
zh:
本 PR 增加了对 Atlas Cloud 对话模型提供商的支持,包含了必要的 API 配置和模型定义。

@CLAassistant

CLAassistant commented Apr 30, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@lucaszhu-hue lucaszhu-hue force-pushed the feat/atlascloud-provider branch from 7810f95 to 4b12708 Compare May 6, 2026 05:49
@lucaszhu-hue

Copy link
Copy Markdown
Author

Hi , sorry for the ping. I've submitted this PR to add Atlas Cloud support for Eino. Could you please help to approve the CI workflows so I can see if the tests pass? Any feedback would be greatly appreciated! Thanks.@JonXSnow

@tangchaojun-bytedance

Copy link
Copy Markdown
Collaborator

@lucaszhu-hue 请关注单测并修复

lucaszhu-hue and others added 3 commits June 8, 2026 13:00
The atlascloud module's go.sum was missing, causing all CI unit-test,
unit-benchmark-test, and compliant checks to fail with "missing go.sum
entry" errors. Running go mod tidy generates the missing checksums.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
- atlascloud_test.go: capture config.BaseURL by value instead of holding a
  pointer to the config inside the mockey closure (the pointed-to value became
  invalid after NewChatModel returned, causing SIGBUS under -race); also fix
  schema.AssistantMessage call to pass the required second arg
- examples/basic/main.go: add Apache 2.0 license header and fix import ordering
@lucaszhu-hue

Copy link
Copy Markdown
Author

@tangchaojun-bytedance 已修复单测问题。根因是单测里的 mockey 闭包保存了指向 NewChatModel 内部局部 config 的指针,函数返回后该指针失效,在 -race 下触发 SIGBUS。改为在闭包里直接捕获 config.BaseURL 的值即可。同时修了 schema.AssistantMessage 缺少第二个参数的调用,并给 example 补上了 Apache license header。本地 go buildgo vetgofmt 以及 go test -race 均已通过。麻烦再触发一下 CI,谢谢!

…e, IsCallbacksEnabled, option functions and error paths
@lucaszhu-hue

Copy link
Copy Markdown
Author

Thanks @tangchaojun-bytedance! Added test coverage for previously uncovered methods (BindTools, BindForcedTools, GetType, IsCallbacksEnabled, option functions, and error paths) to bring coverage above the 70% threshold. Please re-run CI when you get a chance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants