Skip to content

refactor: Only consider subsequent tool result messages after the too…#1052

Merged
tangchaojun-bytedance merged 4 commits into
cloudwego:mainfrom
YellowDusk04:refactor/yd04/optimize-patchtoolcalls-02
May 29, 2026
Merged

refactor: Only consider subsequent tool result messages after the too…#1052
tangchaojun-bytedance merged 4 commits into
cloudwego:mainfrom
YellowDusk04:refactor/yd04/optimize-patchtoolcalls-02

Conversation

@YellowDusk04

Copy link
Copy Markdown
Contributor

优化工具调用响应校验逻辑

仅校验工具调用后连续的工具响应结果,遇到非工具消息立即终止遍历;
原逻辑无此判断,会遍历所有后续消息。

optimize tool call response validation logic

Only check consecutive tool responses after the tool call and stop traversing when a non-tool message is encountered;
The original logic traversed all subsequent messages without this judgment,.

@tangchaojun-bytedance

Copy link
Copy Markdown
Contributor

请解决冲突

@codecov

codecov Bot commented May 29, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 93.33333% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.06%. Comparing base (7491283) to head (70710c6).

Files with missing lines Patch % Lines
adk/middlewares/patchtoolcalls/patchtoolcalls.go 93.33% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1052      +/-   ##
==========================================
+ Coverage   83.01%   83.06%   +0.04%     
==========================================
  Files         162      162              
  Lines       23027    23052      +25     
==========================================
+ Hits        19117    19149      +32     
+ Misses       2653     2648       -5     
+ Partials     1257     1255       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@YellowDusk04

Copy link
Copy Markdown
Contributor Author

请解决冲突

done

@tangchaojun-bytedance

Copy link
Copy Markdown
Contributor

@YellowDusk04 YellowDusk04 force-pushed the refactor/yd04/optimize-patchtoolcalls-02 branch from 33733b2 to 08c416d Compare May 29, 2026 08:09
@YellowDusk04

Copy link
Copy Markdown
Contributor Author

@tangchaojun-bytedance tangchaojun-bytedance merged commit e4abd02 into cloudwego:main May 29, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants