fix(bufiox): ReadBinary returns incorrect n#62
Merged
Conversation
xiaost
force-pushed
the
fix/bufiox-read-binary
branch
from
d2bb70b to
4cf2648
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
ppzqh
previously approved these changes
Feb 12, 2026
Refactored DefaultReader internals and fixed a bug where ReadBinary returned an incorrect byte count n. Key changes: - Merged bufreader.go and bufwriter.go into a single bufiox.go file (Reader + Writer interfaces). - Replaced readExpected with a standalone readAtLeast helper that follows io.ReadAtLeast semantics (returns io.ErrUnexpectedEOF on partial reads). - Added Buffered() method to return the number of bytes that can be read from the current buffer. - Simplified acquire for skip case, advance past buffered data before calling acquire in Skip. - Simplified acquire to return an error instead of a length, and added a panic guard against redundant calls. - Fixed ReadBinary direct-read path: previously sliced bs[:n:len(bs)] and reassigned n from readExpected, losing the already-copied count. Now it accumulates nn from readAtLeast into n correctly. - Added tests for Skip, ReadBinary, and Read covering buffer boundaries, reallocation, EOF, and data preservation.
xiaost
force-pushed
the
fix/bufiox-read-binary
branch
from
4cf2648 to
52b41f7
Compare
ppzqh
approved these changes
Feb 12, 2026
DMwangnima
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored DefaultReader internals and fixed a bug where ReadBinary returned an incorrect byte count n.
Key changes: