Skip to content

test: add unit tests for pkg/common/utils #1310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

orthur2
Copy link

@orthur2 orthur2 commented Mar 23, 2025

What type of PR is this?

test

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.

(Optional) Translate the PR title into Chinese.

测试:为pkg/common/utils添加测试

(Optional) Which issue(s) this PR fixes:

#257

@orthur2 orthur2 requested review from a team as code owners March 23, 2025 10:39
@CLAassistant
Copy link

CLAassistant commented Mar 23, 2025

CLA assistant check
All committers have signed the CLA.

@orthur2
Copy link
Author

orthur2 commented Mar 23, 2025

I don't seem to find information about how to check test coverage in CONTRIBUTING.md. Then, after submitting this PR, codedev didn't perform test coverage detection automatically. I have tried to figure out and found the following error displayed at https://app.codecov.io/gh/cloudwego/hertz/pull/1310:

Missing Head Commit
Unable to compare commits because the head commit was not found

I would really appreciate it if someone could tell me what I did wrong.

orthur2 added a commit to orthur2/hertz that referenced this pull request Mar 23, 2025
What type of PR is this?
test

Check the PR title.
 This PR title match the format: <type>(optional scope): <description>
 The description of this PR title is user-oriented and clear enough for others to understand.
(Optional) Translate the PR title into Chinese.
测试:为pkg/common/utils添加测试

(Optional) Which issue(s) this PR fixes:
orthur2 added 2 commits March 24, 2025 15:14
What type of PR is this?
test

Check the PR title.
 This PR title match the format: <type>(optional scope): <description>
 The description of this PR title is user-oriented and clear enough for others to understand.
(Optional) Translate the PR title into Chinese.
测试:为pkg/common/utils添加测试

(Optional) Which issue(s) this PR fixes:
@xiaost xiaost force-pushed the test/add-unit-tests-for-pkg_common_utils branch from 819e8f0 to dc131d5 Compare March 24, 2025 07:14
@xiaost
Copy link
Contributor

xiaost commented Mar 24, 2025

@orthur2 thanks for contribution. all changes submitted needs to be approved before running tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants