Skip to content

refactor(binding): rm redundant code and perf #1318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

xiaost
Copy link
Contributor

@xiaost xiaost commented Apr 1, 2025

What type of PR is this?

refactor

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

(Optional) The PR that updates user documentation:

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license-eye has totally checked 354 files.

Valid Invalid Ignored Fixed
351 1 2 0
Click to see the invalid file list
  • pkg/app/server/binding/internal/decoder/field.go

@xiaost xiaost force-pushed the refactor-binding branch 2 times, most recently from bffa04c to 6315bd6 Compare April 1, 2025 10:03
Copy link

codecov bot commented Apr 1, 2025

Codecov Report

Attention: Patch coverage is 80.77455% with 139 lines in your changes missing coverage. Please review.

Project coverage is 78.77%. Comparing base (7b021a2) to head (62c00b9).

Files with missing lines Patch % Lines
.../server/binding/internal/decoder/decoder_struct.go 67.70% 19 Missing and 12 partials ⚠️
...p/server/binding/internal/decoder/decoder_slice.go 65.51% 24 Missing and 6 partials ⚠️
...pp/server/binding/internal/decoder/decoder_file.go 62.71% 16 Missing and 6 partials ⚠️
...ver/binding/internal/decoder/decoder_customfunc.go 66.66% 7 Missing and 4 partials ⚠️
...pp/server/binding/internal/decoder/decoder_base.go 91.81% 7 Missing and 2 partials ⚠️
...app/server/binding/internal/decoder/decoder_map.go 55.00% 6 Missing and 3 partials ⚠️
pkg/app/server/binding/internal/decoder/tag.go 78.57% 8 Missing and 1 partial ⚠️
pkg/app/server/binding/internal/decoder/field.go 93.91% 5 Missing and 2 partials ⚠️
pkg/app/server/binding/internal/decoder/decoder.go 72.72% 4 Missing and 2 partials ⚠️
pkg/app/server/binding/internal/decoder/getter.go 90.32% 2 Missing and 1 partial ⚠️
... and 1 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1318      +/-   ##
===========================================
+ Coverage    73.10%   78.77%   +5.67%     
===========================================
  Files          139      139              
  Lines        16315    15925     -390     
===========================================
+ Hits         11927    12545     +618     
+ Misses        3803     2754    -1049     
- Partials       585      626      +41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@xiaost xiaost force-pushed the refactor-binding branch 5 times, most recently from 8730697 to f9b6d05 Compare April 3, 2025 06:31
@xiaost xiaost changed the title WIP: refactor(binding): 1/3 LoC removed & 1x perf increased refactor(binding): rm redundant code and perf Apr 3, 2025
@xiaost xiaost marked this pull request as ready for review April 3, 2025 06:38
@xiaost xiaost requested review from a team as code owners April 3, 2025 06:38
@xiaost xiaost force-pushed the refactor-binding branch from f9b6d05 to 62c00b9 Compare April 22, 2025 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant