Skip to content

Conversation

@DMwangnima
Copy link
Contributor

What type of PR is this?

feat

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

@DMwangnima DMwangnima requested review from a team as code owners December 10, 2025 09:23
@DMwangnima DMwangnima marked this pull request as draft December 10, 2025 09:23
@DMwangnima DMwangnima force-pushed the feat/simplify_client_stream branch 9 times, most recently from 18220b6 to 302ee6d Compare December 11, 2025 12:43
@codecov
Copy link

codecov bot commented Dec 11, 2025

Codecov Report

❌ Patch coverage is 83.08271% with 90 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.66%. Comparing base (bfa27f3) to head (9cae427).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
client/stream_callback.go 86.76% 17 Missing and 1 partial ⚠️
client/stream.go 87.61% 11 Missing and 2 partials ⚠️
pkg/streaming/streamx.go 0.00% 12 Missing ⚠️
pkg/remote/trans/nphttp2/client_conn.go 0.00% 9 Missing ⚠️
pkg/remote/trans/ttstream/exception.go 46.66% 8 Missing ⚠️
client/callopt/streamcall/call_options.go 73.68% 5 Missing ⚠️
client/option_stream.go 66.66% 5 Missing ⚠️
client/client.go 66.66% 2 Missing and 2 partials ⚠️
pkg/remote/trans/ttstream/exception_builder.go 81.81% 4 Missing ⚠️
pkg/remote/trans/ttstream/stream_client.go 82.35% 3 Missing ⚠️
... and 4 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1895      +/-   ##
==========================================
+ Coverage   61.37%   61.66%   +0.28%     
==========================================
  Files         388      393       +5     
  Lines       35063    30321    -4742     
==========================================
- Hits        21521    18697    -2824     
+ Misses      12247    10322    -1925     
- Partials     1295     1302       +7     
Flag Coverage Δ
integration 51.07% <31.01%> (+0.57%) ⬆️
unit 52.16% <81.57%> (+0.51%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@DMwangnima DMwangnima force-pushed the feat/simplify_client_stream branch 2 times, most recently from 21f7d2e to 9cae427 Compare December 11, 2025 12:59
@DMwangnima DMwangnima changed the title feat(streaming): simplify client-side stream using [WIP] feat(streaming): simplify client-side stream using Dec 18, 2025
@DMwangnima DMwangnima force-pushed the feat/simplify_client_stream branch from 9cae427 to 678b367 Compare December 22, 2025 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant