Skip to content

Conversation

@DMwangnima
Copy link
Contributor

What type of PR is this?

feat

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

@DMwangnima DMwangnima requested review from a team as code owners December 29, 2025 05:51
@DMwangnima DMwangnima changed the title feat: streaming remove rpcinfo reuse and add detailed tracing events feat(streaming): remove rpcinfo reuse and add detailed tracing events Dec 29, 2025
@DMwangnima DMwangnima force-pushed the feat/streaming_trace branch 6 times, most recently from 84436a6 to f45e836 Compare January 1, 2026 11:15
@DMwangnima DMwangnima marked this pull request as draft January 4, 2026 17:06
@DMwangnima DMwangnima force-pushed the feat/streaming_trace branch 4 times, most recently from edc9b88 to 070b009 Compare January 7, 2026 07:54
@codecov
Copy link

codecov bot commented Jan 7, 2026

Codecov Report

❌ Patch coverage is 75.35545% with 52 lines in your changes missing coverage. Please review.
✅ Project coverage is 51.43%. Comparing base (bfa27f3) to head (c14a737).
⚠️ Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
pkg/remote/trans/ttstream/stream_client.go 71.05% 8 Missing and 3 partials ⚠️
pkg/rpcinfo/stream_tracer.go 81.66% 7 Missing and 4 partials ⚠️
pkg/remote/trans/ttstream/test_utils.go 0.00% 7 Missing ⚠️
pkg/remote/trans/nphttp2/grpc/trace.go 50.00% 3 Missing and 3 partials ⚠️
client/option_stream.go 0.00% 5 Missing ⚠️
server/option_stream.go 0.00% 5 Missing ⚠️
internal/client/option.go 71.42% 1 Missing and 1 partial ⚠️
internal/server/option.go 50.00% 1 Missing and 1 partial ⚠️
pkg/remote/trans/nphttp2/conn_pool.go 33.33% 1 Missing and 1 partial ⚠️
pkg/remote/trans/ttstream/transport_client.go 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (bfa27f3) and HEAD (c14a737). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (bfa27f3) HEAD (c14a737)
unit 1 0
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1905      +/-   ##
==========================================
- Coverage   61.37%   51.43%   -9.94%     
==========================================
  Files         388      328      -60     
  Lines       35063    22808   -12255     
==========================================
- Hits        21521    11732    -9789     
+ Misses      12247     9746    -2501     
- Partials     1295     1330      +35     
Flag Coverage Δ
integration 51.43% <75.35%> (+0.93%) ⬆️
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@DMwangnima DMwangnima marked this pull request as ready for review January 7, 2026 12:10
@DMwangnima DMwangnima force-pushed the feat/streaming_trace branch from 070b009 to c14a737 Compare January 8, 2026 02:05
@DMwangnima DMwangnima changed the title feat(streaming): remove rpcinfo reuse and add detailed tracing events feat(streaming): support detailed tracing events Jan 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant