refactor(volo-build): adapt to the codegen backend new trait and new codegen context defined in pilota-build#626
Merged
Merged
Conversation
Ggiggle
commented
Oct 28, 2025
Ggiggle
commented
Oct 29, 2025
8245272 to
ec08b79
Compare
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (11.66%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #626 +/- ##
==========================================
+ Coverage 41.96% 43.42% +1.46%
==========================================
Files 160 160
Lines 19806 19355 -451
==========================================
+ Hits 8311 8405 +94
+ Misses 11495 10950 -545 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…codegen context defined in pilota-build Change-Id: I79680ac8fd6b4b657aa965f45c850a461bcc3ab4
…d related examples
…d related examples
a5bd2f5 to
e550e53
Compare
PureWhiteWu
reviewed
Nov 17, 2025
Comment on lines
+104
to
+114
| "client", | ||
| "server", # core | ||
| "http1", | ||
| "http2", # protocol | ||
| "query", | ||
| "form", | ||
| "json", # serde | ||
| "tls", # https | ||
| "cookie", | ||
| "multipart", | ||
| "ws", # exts |
Contributor
There was a problem hiding this comment.
这里保留一下原有的样式吧,看着原来那么拆分是故意的;或者改成下面这样:
Suggested change
| "client", | |
| "server", # core | |
| "http1", | |
| "http2", # protocol | |
| "query", | |
| "form", | |
| "json", # serde | |
| "tls", # https | |
| "cookie", | |
| "multipart", | |
| "ws", # exts | |
| # core | |
| "client", | |
| "server", | |
| # protocol | |
| "http1", | |
| "http2", | |
| # serde | |
| "query", | |
| "form", | |
| "json", | |
| # https | |
| "tls", | |
| # exts | |
| "cookie", | |
| "multipart", | |
| "ws", |
83d8484 to
f454caf
Compare
f454caf to
e3ee355
Compare
PureWhiteWu
approved these changes
Nov 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change-Id: I79680ac8fd6b4b657aa965f45c850a461bcc3ab4
Motivation
We do some refactor for pilota-build in cloudwego/pilota#344 to solve the problem of maintainability.
Solution
Adapt to the new trait and struct defination.