chore(volo): combine rustls and native-tls#627
Merged
Conversation
Contributor
|
bugbot run |
In previous implementation, `volo::net::Conn` has 4 variants: `Tcp`, `Unix`, `Rustls` and `NativeTls`, but we think it's not elegant to put `Rustls` and `NativeTls` here. And what's more, in most cases, we only need to be aware of TLS and do not need to be aware of which library is used behind it. This commit wraps `Rustls` and `NativeTls` into `Tls` prefixed types and makes `Conn` cleaner. Signed-off-by: Yu Li <liyu.yukiteru@bytedance.com>
00411dc to
dd8664c
Compare
Ggiggle
approved these changes
Nov 2, 2025
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (44.02%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #627 +/- ##
==========================================
+ Coverage 40.78% 40.84% +0.05%
==========================================
Files 160 160
Lines 19544 19646 +102
==========================================
+ Hits 7971 8024 +53
- Misses 11573 11622 +49 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
In previous implementation,
volo::net::Connhas 4 variants:Tcp,Unix,RustlsandNativeTls, but we think it's not elegant to putRustlsandNativeTlshere. And what's more, in most cases, we only need to be aware of TLS and do not need to be aware of which library is used behind it.Solution
Wraps
RustlsandNativeTlsintoTlsprefixed types and makesConncleaner.Note
Unifies rustls/native-tls under generic TLS types and updates conn/transport/server paths to use
Tls*, while bumpingvolo,volo-grpc, andvolo-httpversions.TlsStream,TlsConnector,TlsAcceptor,OwnedReadHalf,OwnedWriteHalfinvolo/src/net/tls/*.ConnStream::{Rustls,NativeTls}withConnStream::Tls; updatenegotiated_alpn,peer_addr, and split logic accordingly involo/src/net/conn.rs.ConnStreamvia unifiedTls*types; add builders and ALPN support; markAsyncReadyunsupported for TLS involo/src/net/ready.rs.TlsMakeTransport.volo-http):TlsMakeConnectionnow wraps TLS handshake and returnsConnwithConnInfousing unifiedTlsConnector.ServerTlsConfigandConnStream::Tcponly; import cleanup.volo = "0.11.2"and bump crate to0.4.4.volo-grpc):ServerTlsConfigfor TLS; minor import adjustments.0.11.8and depend onvolo = "0.11.2".volo):io::Result).0.11.2and lockfile updates.Written by Cursor Bugbot for commit a1597ef. This will update automatically on new commits. Configure here.