Skip to content

feat(volo-build): add with_comments option for codegen builder#631

Merged
Ggiggle merged 2 commits into
mainfrom
feat/comment_opt
Dec 29, 2025
Merged

feat(volo-build): add with_comments option for codegen builder#631
Ggiggle merged 2 commits into
mainfrom
feat/comment_opt

Conversation

@Ggiggle

@Ggiggle Ggiggle commented Dec 25, 2025

Copy link
Copy Markdown
Contributor

Motivation

The comments in user idl, will be checked by rust compiler, when these comments are generated in rust file.

Solution

We add a option for the control of comments, so when you need comments codegen, you should make sure that your comments is compatible with rust format.

And we support the yml field with_comments, which is the config for each entry.

@Ggiggle Ggiggle requested review from a team as code owners December 25, 2025 07:50
@Ggiggle Ggiggle force-pushed the feat/comment_opt branch 2 times, most recently from fb5dfa1 to d47e911 Compare December 26, 2025 04:04
@codecov

codecov Bot commented Dec 26, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 43.41%. Comparing base (a7febd1) to head (80fd982).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
volo-build/src/config_builder.rs 0.00% 7 Missing ⚠️
volo-build/src/workspace.rs 0.00% 5 Missing ⚠️
volo-build/src/lib.rs 0.00% 4 Missing ⚠️
volo-cli/src/migrate.rs 0.00% 1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #631      +/-   ##
==========================================
- Coverage   43.42%   43.41%   -0.01%     
==========================================
  Files         160      160              
  Lines       19355    19372      +17     
==========================================
+ Hits         8404     8410       +6     
- Misses      10951    10962      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

PureWhiteWu
PureWhiteWu previously approved these changes Dec 26, 2025
PureWhiteWu
PureWhiteWu previously approved these changes Dec 29, 2025
@Ggiggle Ggiggle merged commit 4613056 into main Dec 29, 2025
15 of 18 checks passed
@Ggiggle Ggiggle deleted the feat/comment_opt branch December 29, 2025 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants