feat(volo): introduce shmipc as transport layer protocol#636
Merged
Conversation
Codecov Report❌ Patch coverage is ❌ Your patch status has failed because the patch coverage (5.12%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #636 +/- ##
==========================================
- Coverage 43.44% 43.28% -0.16%
==========================================
Files 160 160
Lines 19383 19439 +56
==========================================
- Hits 8421 8415 -6
- Misses 10962 11024 +62 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
9e870b7 to
ae235f1
Compare
Signed-off-by: Yu Li <liyu.yukiteru@bytedance.com>
Signed-off-by: Yu Li <liyu.yukiteru@bytedance.com>
f8c2500 to
029d88b
Compare
Contributor
|
@cursor review |
PureWhiteWu
approved these changes
Jan 23, 2026
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 3 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Introduce shmipc as transport layer protocol
Note
Introduces ShmIPC as an optional transport and updates the networking stack to support it, along with a new async IO extension trait.
net::shmipc(address, config, conn, helpers) and feature-gates it behindfeatures = ["shmipc"]net::Address,ConnStream,OwnedReadHalf/OwnedWriteHalf,DefaultIncoming, and dialing to handleShmipcendpoints/streams; TLS explicitly rejectsShmipcnet::ready::AsyncReadywithnet::ext::AsyncExt; updatesBufReaderand thrift default codec bounds to useAsyncExtshmipcfeature where applicable; add--no-shmipcflag for macOS/Windows runs; add coverage jobshmipcandarc-swapdeps and wire feature involoand workspaceWritten by Cursor Bugbot for commit 029d88b. This will update automatically on new commits. Configure here.