Fix: Resolves memory leak caused by using CRAFT detector repeatedly#211
Open
daniellovera wants to merge 2 commits into
Open
Fix: Resolves memory leak caused by using CRAFT detector repeatedly#211daniellovera wants to merge 2 commits into
daniellovera wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix enables garbage collection to appropriately work when
CRAFT-pytorch/test.py
Line 69 in e332dd8
xwe moved to the GPU after we move the forward pass results back to the CPU. Likewise, the same in deletingyandfeatureafter they are no longer needed.See https://pytorch.org/blog/understanding-gpu-memory-2/#why-doesnt-automatic-garbage-collection-work for more detail.
Running
torch.cuda.empty_cache()intest_net()before returning allows nvidia-smi to be accurate.Relevant package versions
torch version 2.2.1+cu121
torchvision 0.17.1+cu121
Hope this helps!