Exclude support, fixes #5 #27
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
February 15, 2014 16:15
Conflicts: src/Clue/PharComposer/Bundler/Explicit.php tests/ExplicitBundlerTest.php
|
Awesome changeset! I'd love to get this in! 👏
I suppose this is still relevant? Is there anything I can do to help push this forward? IIRC either definition should be sufficient and there's little point in providing two definitions for this. I suppose can be verified through a few test cases? |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for excluding files (and directories) as described in #5 and originally implemented in #15.
At the moment I'm unsure if
Package::isBlacklisted()is implemented correctly to exclude files from being added in theExplicitBundler::addFile()method. It should be possible to exclude directories which then must be respected for the files defined via autoload'sfilesandclassmapdefinitions. From the code it seems like it's different from the filter defined inPackage::getBlacklistFilter(), nevertheless I suppose the same functionality is already there, but hidden in how Symfony'sFinderworks.