Conversation
There was a problem hiding this comment.
Pull request overview
This pull request updates the PRELOAD_RACE_DIAL environment variable semantics so that “preload race dial” is disabled by default and only enabled when explicitly configured, and aligns the project documentation/changelog with that behavior.
Changes:
- Changed
PRELOAD_RACE_DIALdefault from enabled to disabled, and updated the runtime enablement logic. - Updated README environment variable documentation to reflect the new default and enablement values.
- Added a changelog entry and bumped the
_worker.jsversion string.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
README.md |
Updates PRELOAD_RACE_DIAL docs to “off by default; enable with 1/true”. |
CHANGELOG |
Records the behavior change for PRELOAD_RACE_DIAL and links to the related commit. |
_worker.js |
Sets the default to disabled and adjusts the env var parsing logic; bumps Version. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| const 访问路径 = url.pathname.slice(1).toLowerCase(); | ||
| 调试日志打印 = ['1', 'true'].includes(env.DEBUG) || 调试日志打印; | ||
| 预加载竞速拨号 = !['0', 'false'].includes(String(env.PRELOAD_RACE_DIAL ?? '').trim().toLowerCase()); | ||
| 预加载竞速拨号 = ['1', 'true'].includes(env.PRELOAD_RACE_DIAL) || 预加载竞速拨号; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the logic and documentation for the
PRELOAD_RACE_DIALenvironment variable, changing its default behavior from enabled to disabled. Now, preloading race dial is off by default and must be explicitly enabled by setting the variable to1ortrue. The README and changelog have been updated to reflect this change, and the relevant code logic has been adjusted accordingly.Environment Variable Logic Update:
PRELOAD_RACE_DIALtofalse(disabled); it is now only enabled if set to1ortrue. [1] [2]Documentation Updates:
README.mdto clarify the new default (disabled) and how to enable the preloading race dial feature.Versioning:
_worker.jsto reflect the new release date.