Skip to content

Conversation

@guitargeek
Copy link
Collaborator

@guitargeek guitargeek commented Oct 30, 2025

This is to test also these older ROOT versions with the more rigurous CTests that come when building Combine standalone with CMake.

Summary by CodeRabbit

Chores

  • Expanded the continuous integration testing matrix by introducing additional release configurations with different compiler versions and architecture specifications to improve build compatibility verification across multiple platform combinations.
  • Maintained all existing release configurations to ensure comprehensive build testing coverage while preparing infrastructure for potential future test scenario expansions.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 30, 2025

Walkthrough

The pull request expands the continuous integration matrix in the CVMFS CI workflow by adding two new LCG (LHC Computing Grid) configurations: LCG_102 with ROOT 6.26.04 and LCG_105 with ROOT 6.30.02, both targeting Ubuntu 22.04 with GCC 11. Existing configurations are retained, with an additional commented entry for future LCG_104 support.

Changes

Cohort / File(s) Summary
CI Matrix Expansion
\.github/workflows/cvmfs-ci\.yml
Added two new LCG release configurations (LCG_102, LCG_105) to the test matrix with corresponding ROOT versions (6.26.04, 6.30.02) and Ubuntu 22.04 GCC 11 architecture. Preserved existing LCG entries and included commented template for future LCG_104 addition.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Poem

🐰 Hop, hop! The CI matrix grows wide,
LCG_102 and 105 now reside,
With ROOT versions new, Ubuntu clean,
The tests shall run on every scene!

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The PR title "[ci] Add also ROOT 6.30 from LCG to the test matrix" accurately describes a real part of the changeset—specifically, the addition of ROOT 6.30.02 (via LCG_105) to the CI matrix. However, the actual changes include two ROOT versions: both 6.26.04 (LCG_102) and 6.30.02 (LCG_105), whereas the title only mentions 6.30. This makes the title partially related to the full scope of the PR, as it captures one of two equally important additions but omits the other.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@vgvassilev vgvassilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me.

@anigamova
Copy link
Collaborator

On hold for now, from 6.30 series we need >= 6.30.09, while LCG provides 6.30.02

This is to test also these older ROOT versions with the more rigurous
CTests that come when building Combine standalone with CMake.
@guitargeek guitargeek changed the title [ci] Add also ROOT 6.26 and 6.30 from LCG to the test matrix [ci] Add also ROOT 6.30 from LCG to the test matrix Oct 30, 2025
@guitargeek guitargeek closed this Nov 5, 2025
@guitargeek guitargeek deleted the lcg_older_root branch November 5, 2025 12:19
@guitargeek guitargeek restored the lcg_older_root branch November 5, 2025 12:20
@guitargeek guitargeek reopened this Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants