add DoubleSidedGausssian pdf #870
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guitargeek
reviewed
Dec 2, 2023
| RooRealProxy sig1 ; | ||
| RooRealProxy sig2 ; | ||
| Double_t evaluate() const ; | ||
|
|
Collaborator
There was a problem hiding this comment.
This class doesn't implement anaytical integral capabilities, so it will be always integrated numerically. That's a major performance hit.
guitargeek
reviewed
Dec 2, 2023
|
|
||
| private: | ||
|
|
||
| Double_t yMax; |
Collaborator
There was a problem hiding this comment.
yMax is not used anywhere, right? Why is it needed?
Collaborator
|
Hi @hjkwon260! Please consider using the equivalent class that is already in RooFit, which also supports analytical normalization integrals, etc.:
It should be avoided that RooFit functionality is duplicated in experiment frameworks, because this puts an unnecessary maintenance burden on the Or did I overlook something and there is a mathematical difference between your |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add DoubleSidedGausssian pdf which is used for boosted H->aa->mumutautau analysis (SUS-23-005/HIG-18-024) for signal modelling.
It compiles/works in local test.