Introduce support for subplots #60
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces support for plotting multiple subplots in the same canvas. A new function aptly called `subplots` lets the user specify a grid layout in which to split the main canvas and returns an object through which the canvas and its subcomponents can be managed for plotting. Various configuration options are available, such as specifying extra space at the top or bottom of the canvas for extra pads which could host e.g. a shared common legend for all the subplots. Two new classes are also introduced. CMSCanvasManager is the type returned by the `subplots` function. It stores all the pads created and gives access to them. Each pad is of type CMSPad, the second main class introduced, which exposes a plot method to plot graphics onto that specific pad, without needing to interact with internal ROOT mechanisms such as gPad. Fixes cms-cat#52 Co-authored-by: Tommaso Tedeschi <[email protected]>
vepadulano
commented
Apr 22, 2025
Comment on lines
+1946
to
+1953
| # This part here is still custom, needs an abstract definition in | ||
| # the function signature to provide the ranges of all the axes | ||
| if row_index % 2 == 0: | ||
| ymin = 0 | ||
| ymax = 400 | ||
| else: | ||
| ymin = 0 | ||
| ymax = 2 |
There was a problem hiding this comment.
Note that this is the last hard-coded part. In principle we should think about adding an (optional) argument to the function so the user can provide the ranges of all axes (or just for the x and y axis once in case they are shared)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces support for plotting multiple subplots in the same canvas. A new function aptly called
subplotslets the user specify a grid layout in which to split the main canvas and returns an object through which the canvas and its subcomponents can be managed for plotting. Various configuration options are available, such as specifying extra space at the top or bottom of the canvas for extra pads which could host e.g. a shared common legend for all the subplots. Two new classes are also introduced. CMSCanvasManager is the type returned by thesubplotsfunction. It stores all the pads created and gives access to them. Each pad is of type CMSPad, the second main class introduced, which exposes a plot method to plot graphics onto that specific pad, without needing to interact with internal ROOT mechanisms such as gPad.Fixes #52
Note that I have added a test and if I execute it locally I get the following image, let me know if it's well placed as is or I should touch somewhere else
