Backport fixes for alphaS running #30

mseidel42 · 2023-06-19T16:15:52Z

As discussed in cms-sw/cmsdist#8552, backported from 8.309.

Deactivated by default, can be activated with:

SigmaProcess:alphaSfixRun = on
MultipartonInteractions:alphaSfixRun = on
SpaceShower:alphaSfixRun = on
TimeShower:alphaSfixRun = on

Should only be used for special samples requested by experts.

This reverts commit 4311abd.

cmsbuild · 2023-06-19T16:16:13Z

A new Pull Request was created by @mseidel42 (Markus Seidel) for branch cms/240.

@cmsbuild, @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.
cms-bot commands are listed here

Saptaparna · 2023-06-19T16:17:48Z

please test

cmsbuild · 2023-06-19T17:36:03Z

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2a683b/33245/summary.html
COMMIT: 4fd6806
CMSSW: CMSSW_13_2_X_2023-06-19-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-externals/pythia8/30/33245/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_2_X_2023-06-19-1100/src/GeneratorInterface/Pythia8Interface/src/BiasedTauDecayer.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_2_X_2023-06-19-1100/src/GeneratorInterface/Pythia8Interface/src/CustomHookFactory.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_2_X_2023-06-19-1100/src/GeneratorInterface/Pythia8Interface/src/P8RndmEngine.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_2_X_2023-06-19-1100/src/GeneratorInterface/Pythia8Interface/src/PTFilterHook.cc
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_2_X_2023-06-19-1100/src/GeneratorInterface/Pythia8Interface/src/BiasedTauDecayer.cc: In constructor 'BiasedTauDecayer::BiasedTauDecayer(Pythia8::Info*, Pythia8::Settings*)':
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_2_X_2023-06-19-1100/src/GeneratorInterface/Pythia8Interface/src/BiasedTauDecayer.cc:13:11: error: 'class Pythia8::TauDecays' has no member named 'initInfoPtr'; did you mean 'Pythia8::Info* Pythia8::TauDecays::infoPtr'? (not accessible from this context)
   13 |   decayer.initInfoPtr(*infoPtr);
      |           ^~~~~~~~~~~
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc11/external/pythia8/306-9d9ae1747ace11daaab64911929fec4a/include/Pythia8/ParticleDecays.h:21,
                 from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc11/external/pythia8/306-9d9ae1747ace11daaab64911929fec4a/include/Pythia8/HadronLevel.h:25,
                 from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc11/external/pythia8/306-9d9ae1747ace11daaab64911929fec4a/include/Pythia8/Pythia.h:24,

smuzaffar · 2023-06-19T18:34:32Z

please test for CMSSW_10_6_X

this is for 10.6.X , so it should be tested against CMSSW_10_6_X IBs

mseidel42 · 2023-06-19T19:43:34Z

Hi Malik, I think I still need to update https://github.com/cms-sw/cmsdist/blob/IB/CMSSW_10_6_X/gcc820/pythia8.spec

The tag should be 4fd6806 then?

cmsbuild · 2023-06-20T00:12:24Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2a683b/33247/summary.html
COMMIT: 4fd6806
CMSSW: CMSSW_10_6_X_2023-06-18-0000/slc7_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-externals/pythia8/30/33247/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 10 lines from the logs
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 35
DQMHistoTests: Total histograms compared: 3170438
DQMHistoTests: Total failures: 2
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3170102
DQMHistoTests: Total skipped: 334
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
Checked 140 log files, 100 edm output root files, 35 DQM output files
TriggerResults: no differences found

mseidel42 · 2023-06-20T08:05:58Z

Created the corresponding cmsdist PR: cms-sw/cmsdist#8555

smuzaffar · 2023-06-20T08:17:39Z

Hi Malik, I think I still need to update https://github.com/cms-sw/cmsdist/blob/IB/CMSSW_10_6_X/gcc820/pythia8.spec

The tag should be 4fd6806 then?

note really, bot is able to test this PR without cmsdist update. see #30 (comment) results for 10.6.X

smuzaffar · 2023-06-20T08:17:50Z

+externals

cmsbuild · 2023-06-20T08:18:01Z

This pull request is fully signed and it will be integrated in one of the next cms/240 IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

cmsbuild · 2023-07-03T17:53:35Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2a683b/33517/summary.html
COMMIT: 5d98ef7
CMSSW: CMSSW_10_6_X_2023-07-02-0000/slc7_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-externals/pythia8/30/33517/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 5 lines from the logs
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 35
DQMHistoTests: Total histograms compared: 3215686
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3215351
DQMHistoTests: Total skipped: 334
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
Checked 144 log files, 103 edm output root files, 35 DQM output files
TriggerResults: no differences found

Saptaparna · 2023-07-04T14:39:05Z

@mseidel42 : final question before merging -- have you run the PR for general cases and does it run fine without introducing any possible anomalies? Let us know, perhaps our validation team needs to cross check? What's your timeline for this PR.

mseidel42 · 2023-07-04T15:08:07Z

Hi Sapta, the new feature is disabled by default, so it should not change anything for default workflows.

To be sure, Alex proposed an extended RelVal in the cmsdist PR: cms-sw/cmsdist#8555 (comment)

smuzaffar · 2023-07-05T11:00:54Z

+externals

Saptaparna · 2023-07-10T12:47:18Z

+1

cmsbuild · 2023-07-10T12:47:41Z

This pull request is fully signed and it will be integrated in one of the next cms/240 IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

smuzaffar · 2023-07-27T08:34:29Z

I see that this is not merged yet. cms-sw/cmsdist#8555 (comment) says that PPD to approve this backport , @rappoccio @perrotta was there any update on it?

lauridsj · 2023-08-07T16:51:29Z

Hi all, I wanted to ask whether there is any update on the merging of this PR (and after that cms-sw/cmsdist#8555)? We would also like to use the fixed alphaS running for the production of the bb4l sample.
Thanks and cheers!
Laurids

mseidel42 · 2023-09-24T09:13:54Z

ping @perrotta @dpiparo @rappoccio

smuzaffar · 2023-09-24T09:35:24Z

please test for CMSSW_10_6_X

just to refresh the tests
@rappoccio, @antoniovilela , this is backport of alphaS fixes to 10.6.X release cycle.

cmsbuild · 2023-09-24T14:41:58Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2a683b/34876/summary.html
COMMIT: 5d98ef7
CMSSW: CMSSW_10_6_X_2023-09-24-0000/slc7_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-externals/pythia8/30/34876/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 35
DQMHistoTests: Total histograms compared: 3215686
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3215351
DQMHistoTests: Total skipped: 334
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
Checked 144 log files, 103 edm output root files, 35 DQM output files
TriggerResults: no differences found

rappoccio · 2023-09-25T16:28:08Z

+1

rappoccio · 2023-09-25T16:28:25Z

merge

mseidel42 added 2 commits June 19, 2023 16:44

Revert "Revert "change to 8240 in to handle high multiplicity bug""

60db869

This reverts commit 4311abd.

Backport alphaS running fix from 8.309

482d318

cmsbuild added orp-pending pending-signatures tests-pending externals-pending labels Jun 19, 2023

mseidel42 mentioned this pull request Jun 19, 2023

Update Pythia to 8.309 cms-sw/cmsdist#8552

Merged

cmsbuild added tests-started tests-rejected and removed tests-pending tests-started labels Jun 19, 2023

cmsbuild added tests-started and removed tests-rejected labels Jun 19, 2023

cmsbuild added tests-approved and removed tests-started labels Jun 20, 2023

mseidel42 mentioned this pull request Jun 20, 2023

[10_6] Backport Pythia fix for alphaS running cms-sw/cmsdist#8555

Merged

cmsbuild added fully-signed externals-approved and removed pending-signatures externals-pending labels Jun 20, 2023

cmsbuild added tests-started and removed tests-rejected labels Jul 3, 2023

cmsbuild added tests-approved and removed tests-started labels Jul 3, 2023

cmsbuild added externals-approved and removed externals-pending labels Jul 5, 2023

cmsbuild added fully-signed generators-approved and removed pending-signatures generators-pending labels Jul 10, 2023

cmsbuild added tests-started and removed tests-approved labels Sep 24, 2023

cmsbuild added tests-approved and removed tests-started labels Sep 24, 2023

cmsbuild added orp-approved and removed orp-pending labels Sep 25, 2023

cmsbuild merged commit bc4d696 into cms-externals:cms/240 Sep 25, 2023

Backport fixes for alphaS running #30

Backport fixes for alphaS running #30

Uh oh!

Conversation

mseidel42 commented Jun 19, 2023

Uh oh!

cmsbuild commented Jun 19, 2023

Uh oh!

Saptaparna commented Jun 19, 2023

Uh oh!

cmsbuild commented Jun 19, 2023

Build

Uh oh!

smuzaffar commented Jun 19, 2023

Uh oh!

mseidel42 commented Jun 19, 2023

Uh oh!

cmsbuild commented Jun 20, 2023

Comparison Summary

Uh oh!

mseidel42 commented Jun 20, 2023

Uh oh!

smuzaffar commented Jun 20, 2023

Uh oh!

smuzaffar commented Jun 20, 2023

Uh oh!

cmsbuild commented Jun 20, 2023

Uh oh!

cmsbuild commented Jul 3, 2023

Comparison Summary

Uh oh!

Saptaparna commented Jul 4, 2023

Uh oh!

mseidel42 commented Jul 4, 2023

Uh oh!

smuzaffar commented Jul 5, 2023

Uh oh!

Saptaparna commented Jul 10, 2023

Uh oh!

cmsbuild commented Jul 10, 2023

Uh oh!

smuzaffar commented Jul 27, 2023

Uh oh!

lauridsj commented Aug 7, 2023

Uh oh!

mseidel42 commented Sep 24, 2023

Uh oh!

smuzaffar commented Sep 24, 2023

Uh oh!

cmsbuild commented Sep 24, 2023

Comparison Summary

Uh oh!

rappoccio commented Sep 25, 2023

Uh oh!

rappoccio commented Sep 25, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants