Skip to content

Fix: ignore lack of commit status for issues #2476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2025
Merged

Fix: ignore lack of commit status for issues #2476

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions process_pr.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2026,7 +2026,7 @@ def process_pr(repo_config, gh, repo, issue, dryRun, cmsbuild_user=None, force=F
# if not extra_labels[ltype]:
# del extra_labels[ltype]

if bot_status is None and issue.state != "open":
if bot_status is None and issue.pull_request and issue.state != "open":
create_status = False

# Always set test pending label
Expand Down Expand Up @@ -2302,7 +2302,8 @@ def process_pr(repo_config, gh, repo, issue, dryRun, cmsbuild_user=None, force=F
if need_external:
labels.append("requires-external")

if (not bot_status) and issue.state != "open":
# Keep old tests state for closed PRs (workaround for missing commit statuses in old PRs)
if not create_status:
labels = [l for l in labels if not l.startswith("tests-")]
labels.extend(l for l in old_labels if l.startswith("tests-"))

Expand Down Expand Up @@ -2357,7 +2358,7 @@ def process_pr(repo_config, gh, repo, issue, dryRun, cmsbuild_user=None, force=F
add_labels = repo_config.ADD_LABELS
except:
pass
if add_labels and create_status:
if add_labels:
issue.edit(labels=list(labels))

if not issue.pull_request:
Expand Down