[BuildRule]Fix for code checks #9575

smuzaffar · 2024-12-13T08:20:41Z

New cmssw-config tag which fixes code-checks. Once this is merged and available in the IBs then

we will open cmssw PR to apply to code-checks ( clang-tidy) on the files which were merged without clang-tidy fixes.
Already open PRs (when updated) might fail code checks

smuzaffar · 2024-12-13T08:20:59Z

cmsbuild · 2024-12-13T08:21:06Z

A new Pull Request was created by @smuzaffar for branch IB/CMSSW_15_0_X/master.

@aandvalenzuela, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

cmsbuild · 2024-12-13T08:21:07Z

cms-bot internal usage

cmsbuild · 2024-12-13T08:37:01Z

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9d4feb/43427/summary.html
COMMIT: 0ab7188
CMSSW: CMSSW_15_0_X_2024-12-12-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9575/43427/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation error when building:

+ cd /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/cms/coral/CORAL_2_3_21-a06072cdf4d39d36e7acac67ae8cef1e
+ echo V09-06-09
+ /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/cms/coral/CORAL_2_3_21-a06072cdf4d39d36e7acac67ae8cef1e/config/updateConfig.py -p CORAL -v CORAL_2_3_21-a06072cdf4d39d36e7acac67ae8cef1e -s V3_00_80 -t /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/cms/coral-tool-conf/100.0-979c92bc71965f26443fe2cc86e2a196 --keys SCRAM_COMPILER=gcc --keys ENABLE_LTO=1 --keys PROJECT_GIT_HASH=CORAL_2_3_21 --keys ENABLE_PGO=0
+ echo -e ''
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.kVKtzD: line 64: /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/BUILDROOT/a06072cdf4d39d36e7acac67ae8cef1e/opt/cmssw/el8_amd64_gcc12/cms/coral/CORAL_2_3_21-a06072cdf4d39d36e7acac67ae8cef1e/config/toolbox/el8_amd64_gcc12/tools/selected/cmssw-config.xml: No such file or directory
error: Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.kVKtzD (%prep)


RPM build errors:
line 37: It's not recommended to have unversioned Obsoletes: Obsoletes: cms+coral+CORAL_2_3_21-a06072cdf4d39d36e7acac67ae8cef1e
Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.kVKtzD (%prep)

cmsbuild · 2024-12-13T08:43:21Z

Pull request #9575 was updated.

cmsbuild · 2024-12-13T08:43:36Z

Pull request #9575 was updated.

smuzaffar · 2024-12-13T08:43:46Z

please test with cms-sw/cmssw#46930

smuzaffar · 2024-12-13T10:15:08Z

please test with cms-sw/cmssw#46930

cmsbuild · 2024-12-13T12:12:36Z

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9d4feb/43432/summary.html
COMMIT: 9c15534
CMSSW: CMSSW_15_0_X_2024-12-12-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9575/43432/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test test-scram-code-checks had ERRORS

Comparison Summary

Summary:

You potentially added 11 lines to the logs
Reco comparison results: 10 differences found in the comparisons
DQMHistoTests: Total files compared: 46
DQMHistoTests: Total histograms compared: 3510017
DQMHistoTests: Total failures: 460
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3509537
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
Checked 202 log files, 172 edm output root files, 46 DQM output files
TriggerResults: no differences found

smuzaffar · 2024-12-16T07:46:24Z

please test with cms-sw/cmssw#46930

cmsbuild · 2024-12-16T07:49:02Z

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9d4feb/43460/summary.html
COMMIT: 9c15534
CMSSW: CMSSW_15_0_X_2024-12-15-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/9575/43460/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation error when building:

FATAL: malformed spec found while quering it. Command: 
source /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/rpm-env.sh ;  rpm -q --specfile /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/tmpspec-coral --info --define "cmsdist_directory /data/cmsbld/jenkins/workspace/ib-run-pr-tests/cmsdist" --define "compilerv 1231" --define "cmscompilerv 12" --define "cmsos el8_amd64" --define "almalinux_ver 8" --define "almalinux 8" --define "centos_ver 8" --define "centos 8" --define "rhel 8" --define "dist .el8" --define "el8 1" --define "package_vectorization x86-64-v2" --define "cmsswdata_version_link 1"  --define 'buildroot /foo'
Resulted in:

warning: line 30: It's not recommended to have unversioned Obsoletes: Obsoletes: cms+coral+CORAL_2_3_21
error: line 480: Unknown tag: <<<<<<< HEAD
error: query of specfile /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/tmpspec-coral failed, can't parse
Traceback (most recent call last):
  File "./pkgtools/cmsBuild", line 5075, in 
    build(opts, args[1:], PKGFactory)
  File "./pkgtools/cmsBuild", line 4240, in build

smuzaffar · 2024-12-16T07:52:22Z

please test with cms-sw/cmssw#46930

cmsbuild · 2024-12-16T07:52:35Z

Pull request #9575 was updated.

cmsbuild · 2024-12-16T11:10:51Z

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9d4feb/43465/summary.html
COMMIT: c987c9b
CMSSW: CMSSW_15_0_X_2024-12-15-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/9575/43465/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test test-scram-code-checks had ERRORS

Comparison Summary

Summary:

You potentially added 14 lines to the logs
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 46
DQMHistoTests: Total histograms compared: 3510017
DQMHistoTests: Total failures: 457
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3509540
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
Checked 202 log files, 172 edm output root files, 46 DQM output files
TriggerResults: found differences in 1 / 44 workflows

smuzaffar · 2024-12-17T13:08:10Z

please test

cmsbuild · 2024-12-17T15:38:15Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9d4feb/43501/summary.html
COMMIT: c987c9b
CMSSW: CMSSW_15_0_X_2024-12-16-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/9575/43501/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

@cms-sw Added git-lfs and update git to version 2.47.1 #9569

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9d4feb/43501/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9d4feb/43501/git-merge-result

Comparison Summary

Summary:

You potentially added 14 lines to the logs
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 46
DQMHistoTests: Total histograms compared: 3510017
DQMHistoTests: Total failures: 434
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3509563
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
Checked 202 log files, 172 edm output root files, 46 DQM output files
TriggerResults: no differences found

[BuildRule]Fix for code checks

0ab7188

cmsbuild added externals-pending pending-signatures tests-started orp-pending requires-external labels Dec 13, 2024

smuzaffar mentioned this pull request Dec 13, 2024

Update clang-tidy test cms-sw/cmssw#46930

Merged

cmsbuild added tests-rejected and removed tests-started labels Dec 13, 2024

move creation of of cmssw-config.xml at correct place

ed0f4f4

cmsbuild added tests-pending and removed tests-rejected requires-external labels Dec 13, 2024

Update scram-project-build.file

9c15534

cmsbuild added tests-started requires-external and removed tests-pending labels Dec 13, 2024

cmsbuild added tests-rejected and removed tests-started labels Dec 13, 2024

cmsbuild removed the tests-rejected label Dec 16, 2024

cmsbuild added the tests-started label Dec 16, 2024

cmsbuild added tests-rejected and removed tests-started labels Dec 16, 2024

Merge branch 'IB/CMSSW_15_0_X/master' into code-checks-fix

c987c9b

cmsbuild added tests-started and removed tests-rejected labels Dec 16, 2024

cmsbuild added tests-rejected and removed tests-started labels Dec 16, 2024

cmsbuild added tests-started and removed requires-external tests-rejected labels Dec 17, 2024

smuzaffar merged commit c707746 into IB/CMSSW_15_0_X/master Dec 17, 2024
9 of 10 checks passed

cmsbuild added tests-approved and removed tests-started labels Dec 17, 2024

This was referenced Dec 17, 2024

[BuildRules] patch release build fix: use realpath for import python module #9583

Merged

MTD Geometry - Numbering scheme update cms-sw/cmssw#46977

Merged

[BuildRules] For PR test: drop additional microarch release/externals lib/bindirs #9584

Merged

smuzaffar deleted the code-checks-fix branch December 18, 2024 14:34

cmsbuild mentioned this pull request Jan 8, 2025

[ROOT634]Updated root to tip of branch v6-34-00-patches #9598

Merged

[BuildRule]Fix for code checks #9575

[BuildRule]Fix for code checks #9575

Uh oh!

Conversation

smuzaffar commented Dec 13, 2024

Uh oh!

smuzaffar commented Dec 13, 2024

Uh oh!

cmsbuild commented Dec 13, 2024

Uh oh!

cmsbuild commented Dec 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented Dec 13, 2024

External Build

Uh oh!

cmsbuild commented Dec 13, 2024

Uh oh!

cmsbuild commented Dec 13, 2024

Uh oh!

smuzaffar commented Dec 13, 2024

Uh oh!

smuzaffar commented Dec 13, 2024

Uh oh!

cmsbuild commented Dec 13, 2024

Unit Tests

Comparison Summary

Uh oh!

smuzaffar commented Dec 16, 2024

Uh oh!

cmsbuild commented Dec 16, 2024

External Build

Uh oh!

smuzaffar commented Dec 16, 2024

Uh oh!

cmsbuild commented Dec 16, 2024

Uh oh!

cmsbuild commented Dec 16, 2024

Unit Tests

Comparison Summary

Uh oh!

smuzaffar commented Dec 17, 2024

Uh oh!

Uh oh!

cmsbuild commented Dec 17, 2024

Comparison Summary

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

cmsbuild commented Dec 13, 2024 •

edited

Loading