Split the dR plot for neutral hadrons in two eta ranges in the EB (ma… #42009
Conversation
…inly intended for Phase2)
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42009/35971
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
|
Sorry about the delay, it should now be fixed
…________________________________
From: cmsbuild ***@***.***>
Sent: Monday, June 19, 2023 15:28
To: cms-sw/cmssw ***@***.***>
Cc: Nancy Marinelli ***@***.***>; Author ***@***.***>
Subject: Re: [cms-sw/cmssw] Split the dR plot for neutral hadrons in two eta ranges in the EB (ma… (PR #42009)
-code-checks
Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42009/35971
* This PR adds an extra 48KB to repository
* There are other open Pull requests which might conflict with changes you have proposed:
* File Validation/RecoEgamma/plugins/PhotonValidator.cc modified in PR(s): #41987<#41987>
* File Validation/RecoEgamma/plugins/PhotonValidator.h modified in PR(s): #41987<#41987>
Code check has found code style and quality issues which could be resolved by applying following patch(s)
* code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42009/35971/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42009/35971/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly
—
Reply to this email directly, view it on GitHub<#42009 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABC6G2XOCH4LDIOXNAO2PATXMBHZVANCNFSM6AAAAAAZL6FWHU>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
type egamma |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42009/36083
|
|
A new Pull Request was created by @nancymarinelli for master. It involves the following packages:
@nothingface0, @emanueleusai, @cmsbuild, @pmandrik, @syuvivida, @tjavaid, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
-1 Failed Tests: ClangBuild Clang BuildI found compilation warning while trying to compile with clang. Command used: See details on the summary page. |
|
Sorry, not clear what I should be doing here to finally have the PR accepted
On 28.06.23 06:46, cmsbuild wrote:
…-1
Failed Tests: ClangBuild
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-59077c/33428/summary.html
COMMIT: 03c82a2<03c82a2>
CMSSW: CMSSW_13_2_X_2023-06-27-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42009/33428/install.sh to create a dev area with all the needed externals and cmssw changes.
Clang Build
I found compilation warning while trying to compile with clang. Command used:
USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 32 COMPILER='llvm compile'
See details on the summary page.
—
Reply to this email directly, view it on GitHub<#42009 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABC6G2TGQJIQEBNACL7IEETXNOZJ7ANCNFSM6AAAAAAZL6FWHU>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
--
Nancy Marinelli
Research Professor
University of Notre Dame, IN, US
CERN, Bdg 40/3-A01, 1211 Geneva
SWITZERLAND
Phone +41-22-76-70809
fax +41-22-76-78940
|
|
Hi Nancy, in the tests the compiler produced warnings that supposedly come from the code in this PR. The code should be modified so that there are no compilation warnings. You should also be able to reproduce the warnings running this: and then compiling with: |
|
please test |
|
thanks.
How do I run /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42009/33428/install.sh
I tried source file but it did not work.
Then compiling means scram b USER_CUDA_FLAGS=' etc etc or else ?
Sorry if the questions are naive. I never fell in this ... case.
Thanks,
Nancy
On 19.07.23 00:10, Emanuele Usai wrote:
Hi Nancy,
in the tests the compiler produced warnings that supposedly come from the code in this PR. The code should be modified so that there are no compilation warnings.
Now, I cannot see the warnings because the tests are old and the results have been deleted. I'll re-trigger the tests.
You should also be able to reproduce the warnings running this:
/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42009/33428/install.sh
and then compiling with:
USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 32 COMPILER='llvm compile'
—
Reply to this email directly, view it on GitHub<#42009 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABC6G2WFNFKGJRWNL6L67RDXQ4CWBANCNFSM6AAAAAAZL6FWHU>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
…--
Nancy Marinelli
Research Professor
University of Notre Dame, IN, US
CERN, Bdg 40/3-A01, 1211 Geneva
SWITZERLAND
Phone +41-22-76-70809
fax +41-22-76-78940
|
|
-1 Failed Tests: ClangBuild Clang BuildI found compilation warning while trying to compile with clang. Command used: See details on the summary page. |
|
The test ran pretty quick so now we can see what triggered the warnings without running the commands. Here are the warnings: Validation/RecoEgamma/plugins/PhotonValidator.cc It looks like iTrk and nHits are set, but not used anywhere and could be deleted. |
|
Yes, thanks !
Will fix it later today.
Nancy
…On 19.07.23 00:49, Emanuele Usai wrote:
The test ran pretty quick so now we can see what triggered the
warnings without running the commands. Here are the warnings:
Validation/RecoEgamma/plugins/PhotonValidator.cc
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_3_X_2023-07-18-1100/src/Validation/RecoEgamma/plugins/PhotonValidator.cc:3245:9:
warning: variable 'iTrk' set but not used [-Wunused-but-set-variable]
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_3_X_2023-07-18-1100/src/Validation/RecoEgamma/plugins/PhotonValidator.cc:3246:9:
warning: variable 'nHits' set but not used [-Wunused-but-set-variable]
It looks like iTrk and nHits are set, but not used anywhere and could
be deleted.
—
Reply to this email directly, view it on GitHub
<#42009 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABC6G2SRN6AOAD436WOI4NTXQ4HHPANCNFSM6AAAAAAZL6FWHU>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
Nancy Marinelli
Research Professor
University of Notre Dame, IN, US
CERN, Bdg 40/3-A01, 1211 Geneva
SWITZERLAND
Phone +41-22-76-70809
fax +41-22-76-78940
--------------KdROR0mmqAp17UzAGy9ZDWTW
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: 8bit
<html><head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body>
Yes, thanks ! <br>
Will fix it later today. <br>
Nancy<br>
<br>
<div class="moz-cite-prefix">On 19.07.23 00:49, Emanuele Usai wrote:<br>
</div>
<blockquote type="cite" ***@***.***">
<p dir="auto">The test ran pretty quick so now we can see what
triggered the warnings without running the commands. Here are
the warnings:</p>
<p dir="auto">Validation/RecoEgamma/plugins/PhotonValidator.cc<br>
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_3_X_2023-07-18-1100/src/Validation/RecoEgamma/plugins/PhotonValidator.cc:3245:9:
warning: variable 'iTrk' set but not used
[-Wunused-but-set-variable]<br>
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_3_X_2023-07-18-1100/src/Validation/RecoEgamma/plugins/PhotonValidator.cc:3246:9:
warning: variable 'nHits' set but not used
[-Wunused-but-set-variable]</p>
<p dir="auto">It looks like iTrk and nHits are set, but not used
anywhere and could be deleted.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br>
Reply to this email directly, <a href="#42009 (comment)" moz-do-not-send="true">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABC6G2SRN6AOAD436WOI4NTXQ4HHPANCNFSM6AAAAAAZL6FWHU" moz-do-not-send="true">unsubscribe</a>.<br>
You are receiving this because you were mentioned.<img src="https://github.com/notifications/beacon/ABC6G2SZEXGK2BAALFUIOATXQ4HHPA5CNFSM6AAAAAAZL6FWHWWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTB2ECFC.gif" alt="" moz-do-not-send="true" width="1" height="1"><span style="color: transparent; font-size: 0; display: none;
visibility: hidden; overflow: hidden; opacity: 0; width: 0;
height: 0; max-width: 0; max-height: 0; mso-hide: all">Message
ID: <span><cms-sw/cmssw/pull/42009/c1641088081</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
***@***.***": "http://schema.org",
***@***.***": "EmailMessage",
"potentialAction": {
***@***.***": "ViewAction",
"target": "#42009 (comment)",
"url": "#42009 (comment)",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
***@***.***": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>
</blockquote>
<br>
<pre class="moz-signature" cols="72">--
Nancy Marinelli
Research Professor
University of Notre Dame, IN, US
CERN, Bdg 40/3-A01, 1211 Geneva
SWITZERLAND
Phone +41-22-76-70809
fax +41-22-76-78940</pre>
</body>
</html>
--------------KdROR0mmqAp17UzAGy9ZDWTW--
|
PR description:
Minor update in Validation/RecoEgamma/plugins/PhotonValidator.cc, .h. The plot in EB of dR between PF photon candidate and PF neutral hadron candidates is now split
in two |eta| regions (<1 and >1) mainly needed for Phase2, where |eta| >1 receives contributions from the HGCAL reco
PR validation:
Test was made locally using the cmsDriver for PhaseI and PhaseII on the HggGluonfusion sample. All works fine
This PR needs to be backported to the 13_1_X series