Skip to content

By-pass scalers input collection for hltScalersRawToDigi for Heavy Ions pp-reco workflows post merge of #41815 #42087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 26, 2023

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Jun 26, 2023

PR description:

Title says it all, address #41815 (comment). Done similarly as previously done for siStripDigisHLT collection.

PR validation:

runTheMatrix.py -l 159.02,159.03,160.02,160.03

runs fine.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

Cc: @Ksavva1021

@mmusich
Copy link
Contributor Author

mmusich commented Jun 26, 2023

type bug-fix

@mmusich
Copy link
Contributor Author

mmusich commented Jun 26, 2023

test parameters:

  • workflows = 159.02,159.03,160.02,160.03,140.58,140.60

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42087/36069

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

  • Configuration/PyReleaseValidation (pdmv, upgrade)

@cmsbuild, @bbilin, @srimanob, @sunilUIET, @AdrianoDee can you please review it and eventually sign? Thanks.
@makortel, @kpedro88, @Martin-Grunewald, @missirol, @fabiocos, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Jun 26, 2023

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cd9674/33384/summary.html
COMMIT: 0d34518
CMSSW: CMSSW_13_2_X_2023-06-25-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42087/33384/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 67 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3307432
  • DQMHistoTests: Total failures: 4
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3307406
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 226 log files, 174 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor Author

mmusich commented Jun 26, 2023

urgent

  • to fix IBs

@AdrianoDee
Copy link
Contributor

+upgrade

@perrotta
Copy link
Contributor

+1

  • Workflows failing in the IB succeed with this PR
  • @cms-sw/pdmv-l2 while we merge it to fix the IBs, feel free to suggest and provide a different fix if you think this is not the correct one

@perrotta
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit e385c78 into cms-sw:master Jun 26, 2023
@mmusich mmusich deleted the fixFor41815 branch June 26, 2023 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants