Skip to content

LHCInfo* inspection and validation tools #42841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

JanChyczynski
Copy link
Contributor

PR description:

draft PR, description coming soon

PR validation:

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42841/36972

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42841/36992

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 25, 2023

A new Pull Request was created by @JanChyczynski (jan_chyczynski) for master.

It involves the following packages:

  • CondTools/RunInfo (db)

@perrotta, @cmsbuild, @consuegs, @saumyaphor4252, @francescobrivio can you please review it and eventually sign? Thanks.
@mmusich this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@smuzaffar
Copy link
Contributor

Milestone for this pull request has been moved to CMSSW_14_0_X.Please open a backport if it should also go in to CMSSW_13_3_X.

@smuzaffar smuzaffar modified the milestones: CMSSW_13_3_X, CMSSW_14_0_X Nov 6, 2023
@cmsbuild cmsbuild modified the milestones: CMSSW_14_0_X, CMSSW_13_3_X Nov 6, 2023
@JanChyczynski JanChyczynski force-pushed the LHCInfoXxxx_inspection_and_validation_tools branch from fe7d0b2 to 4366f9e Compare January 4, 2024 17:51
@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 4, 2024

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42841/38318

  • This PR adds an extra 28KB to repository

  • Found files with invalid states:

    • CondTools/RunInfo/test/dump_LHCInfoPer_payloads.py:
    • CondTools/RunInfo/test/LHCInfoPerLSAnalyzer_cfg.py:
    • CondTools/RunInfo/python/ppsLHCInfoPerLSComp.py:

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 4, 2024

Pull request #42841 was updated. @perrotta, @cmsbuild, @saumyaphor4252, @consuegs, @francescobrivio can you please check and sign again.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42841/39670

@cmsbuild
Copy link
Contributor

Pull request #42841 was updated. @saumyaphor4252, @francescobrivio, @cmsbuild, @consuegs, @perrotta can you please check and sign again.

@cmsbuild
Copy link
Contributor

Milestone for this pull request has been moved to CMSSW_14_2_X. Please open a backport if it should also go in to CMSSW_14_1_X.

@cmsbuild cmsbuild modified the milestones: CMSSW_14_1_X, CMSSW_14_2_X Aug 27, 2024
@antoniovilela
Copy link
Contributor

ping (to make bot change milestone)

@cmsbuild cmsbuild modified the milestones: CMSSW_14_1_X, CMSSW_14_2_X Sep 3, 2024
@cmsbuild
Copy link
Contributor

Milestone for this pull request has been moved to CMSSW_15_0_X. Please open a backport if it should also go in to CMSSW_14_2_X.

@cmsbuild cmsbuild modified the milestones: CMSSW_14_2_X, CMSSW_15_0_X Nov 22, 2024
@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2025

Milestone for this pull request has been moved to CMSSW_15_1_X. Please open a backport if it should also go in to CMSSW_15_0_X.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants