Fixes/impovements towards the first production version of the custom muon DPG NANO

[battibass]

PR description:

Update of common muon ntuple content + fixes based on feedback from analysers/users:

• fix bug generating broken flat table in CSC TnP producer
• add missing information to allow DT TnP analysis
• add CSC/DT segment extrapolation to nearby RPC chambers
• fix propagation issue in GEMMuonExtTable producer
• add producer writing online luminosity information

Last report at xPOG workshop

PR validation:

Compilation and use in private production (ran using 13_0_X and covering Run2023_v1) for now. Though cmsDriver.py customisations are available, ntuple production is not included, at present, in any central workflow.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43065/37267

• This PR adds an extra 40KB to repository

[cmsbuild]

A new Pull Request was created by @battibass (Carlo Battilana) for master.

It involves the following packages:

• DPGAnalysis/MuonTools (xpog)
• PhysicsTools/NanoAOD (xpog)

@cmsbuild, @simonepigazzini, @vlimant can you please review it and eventually sign? Thanks.
@gpetruc, @AnnikaStein this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[battibass]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-240818/35287/summary.html
COMMIT: 73ba01e
CMSSW: CMSSW_13_3_X_2023-10-19-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43065/35287/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3357400
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3357375
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 214 log files, 167 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[vlimant]

have we discussed a way to include a validation workflow in the nano matrix @battibass ?

[battibass]

@vlimant, unless I forgot (thing that might well be possible) we spoke about the fact that this should be done, but never nailed down all details.

Anyhow, I am happy to agree on how to properly add a workflow to the nano matrix and include it in this PR, if you think this the best way to proceed.

[smuzaffar]

Milestone for this pull request has been moved to CMSSW_14_0_X.Please open a backport if it should also go in to CMSSW_13_3_X.

[AdrianoDee]

test parameters:

• workflows = 2500.313,2500.312

[AdrianoDee]

test parameters:

• workflows_nano = 2500.313,2500.312

[AdrianoDee]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-240818/35978/summary.html
COMMIT: 469b433
CMSSW: CMSSW_14_0_X_2023-11-21-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43065/35978/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 1 lines from the logs
• Reco comparison results: 133 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3363868
• DQMHistoTests: Total failures: 1791
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3362055
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 214 log files, 167 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[srimanob]

+Upgrade

2 new workflows run fine.

[AdrianoDee]

+pdmv
workflow-wise everything's good

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

[antoniovilela]

+1